Thu, 20 Nov 2008 08:39:46 -0500 http://bugs.horde.org/ticket/6982 Optimized Tags The UNION ALL SELECT query is very waste full SQL command. Expecially with the kind of table that tags are implemented with. Is taking seconds for my installations with a lot of images. As the server must read all table data to perform the counting and proper selection of data. So we must help the server and perform the count on the rare update operations to have fast common selections. The patch: reorganize the Ansel_Tags object store the store counts of used tags in the tags table to not count on the fly mark galleries and images if they have tags or not so we can avoid not needed queries with all galleries and images that does not have tags. Add limit functionality to the tags cloud block Thu, 26 Jun 2008 10:49:39 -0400 http://bugs.horde.org/ticket/6982#t46874 and why not, a tag cloud page... Thu, 26 Jun 2008 10:51:08 -0400 http://bugs.horde.org/ticket/6982#t46875 I'm still looking over the changes here, but why do the iteration/concatenation in gallery.php instead of using implode()? Is there a big performance difference? Mon, 30 Jun 2008 09:33:40 -0400 http://bugs.horde.org/ticket/6982#t46989 > I'm still looking over the changes here, but why do the > iteration/concatenation in gallery.php instead of using implode()? > Is there a big performance difference? becouse getTags() does not return one dimentional array anymore but even the tag count Mon, 30 Jun 2008 09:37:33 -0400 http://bugs.horde.org/ticket/6982#t46990 > and why not, a tag cloud page... To be honest, I feel that an entire page containing only a tag cloud is a bit, well, boring and wasteful considering that the "Browse" page can be configured with a cloud of whatever size the user wants. I suppose I can be convinced differently if there is a compelling reason that I am missing or the Cloud page contained some other widgets/info etc... Mon, 30 Jun 2008 09:38:25 -0400 http://bugs.horde.org/ticket/6982#t46991 >> and why not, a tag cloud page... > > To be honest, I feel that an entire page containing only a tag cloud > is a bit, well, boring and wasteful considering that the "Browse" > page can be configured with a cloud of whatever size the user wants. I agree. Mon, 30 Jun 2008 09:56:46 -0400 http://bugs.horde.org/ticket/6982#t47001 It looks like these changes will cause the tag_count field to be overwritten with the count of tags in *either* the ansel_images_tags or ansel_galleries_tags table...when it should be both. Mon, 30 Jun 2008 11:54:13 -0400 http://bugs.horde.org/ticket/6982#t47004 > It looks like these changes will cause the tag_count field to be > overwritten with the count of tags in *either* the ansel_images_tags > or ansel_galleries_tags table...when it should be both. Actually we don't need to know the actual number of images/galleries tag count. Is used only as a flag if the gallery/image has tags or not to save later queries. So this can be a boolean value. Wed, 02 Jul 2008 03:56:22 -0400 http://bugs.horde.org/ticket/6982#t47097 > Actually we don't need to know the actual number of images/galleries > tag count. Is used only as a flag if the gallery/image has tags or > not to save later queries. So this can be a boolean value. Huh? Your saving the actual number of tags in ansel_tags.tag_count and then your using the value of that field directly in Ansel_Tags::readTags() and Ansel_Tags::listTagInfo(). With your changes, once any tags are added/removed from an image or gallery, the tag counts will never be correct because the value in the ansel_tags.tag_count field is only taking into account the number of times that tag is used in _either_ the images table *or* the galleries table, when it needs to be both. Wed, 02 Jul 2008 16:49:01 -0400 http://bugs.horde.org/ticket/6982#t47124 > Huh? Your saving the actual number of tags in ansel_tags.tag_count Sorry, that should be "the actual number of times that a tag is used in..." Wed, 02 Jul 2008 16:50:17 -0400 http://bugs.horde.org/ticket/6982#t47125 Removing as a showstopper, tags work, this would be a nice performance enhancement though, once the gallery vs image tag count issue is resolved. Tue, 15 Jul 2008 23:29:49 -0400 http://bugs.horde.org/ticket/6982#t47566 An extremely simplistic idea for better tag-related queries: http://blogs.sun.com/dups/entry/having_a_grand_old_time Going to try to refactor Ansel's tag code to see what this gets us, what other issues it might bring up etc.... Mon, 20 Oct 2008 14:56:34 -0400 http://bugs.horde.org/ticket/6982#t49853 followup on the having() idea: http://blogs.sun.com/dups/entry/having_a_follow_up Tue, 21 Oct 2008 17:02:17 -0400 http://bugs.horde.org/ticket/6982#t49873 > Removing as a showstopper, tags work, this would be a nice > performance enhancement though, once the gallery vs image tag count > issue is resolved. And here it is solved. When we fill the ansel_tags table we count both images and galleries table. To be more simple, I reduced the amount of changes just to introduce the tag_count column and avoid the double UNION SELECT. Other performance patches will come after this will be commited. Fri, 31 Oct 2008 12:21:38 -0400 http://bugs.horde.org/ticket/6982#t50224 1) This patch does nothing to update the count when a tag is removed. You only updating the tags that are passed to Ansel_Tags::writeTags() this function *always* overwrites the resources's tags, so your not capturing when the tag is removed. 2) Was there any special reason you removed the charset conversion is some of the queries? 3) the variable $id is not always set, that is why I was using the $reults['tag_id'] value - any special reason you didn't want to use that? Wed, 12 Nov 2008 19:55:41 -0500 http://bugs.horde.org/ticket/6982#t50712 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/ansel/lib/Tags.php?r1=1.87&r2=1.88&ty=u Wed, 12 Nov 2008 20:46:14 -0500 http://bugs.horde.org/ticket/6982#t50714 In the meantime, I changed the search queries to use GROUP BY / HAVING to start comparing it with the queries that we had...any feed back on performance is welcome. I'm going to port these changes over to my production server data and see what it gets us. Wed, 12 Nov 2008 20:48:01 -0500 http://bugs.horde.org/ticket/6982#t50715