Thu, 20 Nov 2008 10:07:40 -0500 http://bugs.horde.org/ticket/6981 Statically cache images and galleries In practice came out that is not so good to store galleries in cache. As the gallery is requestioned multiply times in the page the cache is called multiply times too. Is better to statically handle galleries. The patch replaces the cache storage witch classic static calls and and move the static images container in the the main Ansel_Storage level so it can be filled by others functions. Thu, 26 Jun 2008 10:25:16 -0400 http://bugs.horde.org/ticket/6981#t46868 And of course the pach :) The patch removes the use of Horde_Cache for galleries but it can be left, if you think that is better, But static calls should be added for sure. Thu, 26 Jun 2008 10:27:12 -0400 http://bugs.horde.org/ticket/6981#t46869 The cache holds galleries requested by ALL users so you can get a hit on the cache by a user that is requesting a particular gallery for the first time if another user already requested it, your patch can end up having to retrieve (and store in memory) the same gallery from the DB once for every user instead of only when the gallery cache is expired. What is the performance issue with using the cache? If you choose not to use the cache, that's what the cache configuration parameter in Ansel is for. Or am I missing something? Thu, 26 Jun 2008 11:00:34 -0400 http://bugs.horde.org/ticket/6981#t46878 you are hitting the cache (ex. an remote memcached server) multiply times on the same page for the same gallery. Thu, 26 Jun 2008 11:18:17 -0400 http://bugs.horde.org/ticket/6981#t46880 Ah. Makes sense. I'd prefer to keep the Gallery Cache though - it can still be turned off in the config if that is desired and l want to look and see what code paths would lead to the images that are pulled from getImages() to be accessed again on the same page....I'd hate to always cache the image object on every gallery page load...that is a lot of images, with the image data already loaded, to keep in memory. Thu, 26 Jun 2008 12:14:49 -0400 http://bugs.horde.org/ticket/6981#t46889 What about doing something like http://schlitt.info/applications/blog/index.php?/archives/605-Hierarchical-caching.html and adding a local-memory cache? That way the cache could transparently handle things that should be returned from local memory, then fall back to memcache (if enabled), then fall back to disk/sql. Thu, 26 Jun 2008 13:27:43 -0400 http://bugs.horde.org/ticket/6981#t46893 > Ah. Makes sense. I'd prefer to keep the Gallery Cache though Done Mon, 30 Jun 2008 13:12:40 -0400 http://bugs.horde.org/ticket/6981#t47012 > What about doing something like > http://schlitt.info/applications/blog/index.php?/archives/605-Hierarchical-caching.html and adding a local-memory cache? That way the cache could transparently handle things that should be returned from local memory, then fall back to memcache (if enabled), then fall back to > disk/sql. For the record, this won't go into Ansel, but into Framework. Probably for Horde 4. See Ticket: 6996 Tue, 01 Jul 2008 13:08:09 -0400 http://bugs.horde.org/ticket/6981#t47074 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/ansel/lib/Ansel.php?r1=1.452&r2=1.453&ty=u Tue, 01 Jul 2008 13:32:59 -0400 http://bugs.horde.org/ticket/6981#t47075 Committed, thanks. Tue, 01 Jul 2008 13:34:56 -0400 http://bugs.horde.org/ticket/6981#t47076 I don't see where you are calling your new Ansel_Storage::destroy() method anywhere in the code. Where is this intended to be called? Tue, 01 Jul 2008 13:43:12 -0400 http://bugs.horde.org/ticket/6981#t47077 > I don't see where you are calling your new Ansel_Storage::destroy() > method anywhere in the code. Where is this intended to be called? http://www.alexatnet.com/node/73 Wed, 02 Jul 2008 00:30:20 -0400 http://bugs.horde.org/ticket/6981#t47082 >> I don't see where you are calling your new Ansel_Storage::destroy() >> method anywhere in the code. Where is this intended to be called? > > http://www.alexatnet.com/node/73 Eh? The method still needs to be called to be useful... Wed, 02 Jul 2008 00:37:52 -0400 http://bugs.horde.org/ticket/6981#t47084 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/ansel/lib/Ansel.php?r1=1.458&r2=1.459&ty=u Sat, 05 Jul 2008 12:27:03 -0400 http://bugs.horde.org/ticket/6981#t47240 Removed the destroy() method, it's never called, and even if we were to call it, it would serve no purpose since the only logical place to use it would be at the end of script execution, when all objects are destroyed anyway. The article mentioned refers to removing circular references when objects go out of scope and are unused - these are not circular references nor do we know for sure when we want to destroy them, other then at request shutdown. Sat, 05 Jul 2008 12:31:02 -0400 http://bugs.horde.org/ticket/6981#t47241