Tickets :: [#6962] recursive delete

6.0.0-beta1

7/5/25

Summary	recursive delete
Queue	Trean
Type	Enhancement
State	Rejected
Priority	2. Medium
Owners
Requester	felix.leimbach (at) gmx (dot) net
Created	06/20/2008 (6224 days ago)
Due
Updated	11/13/2011 (4983 days ago)
Assigned
Resolved	11/13/2011 (4983 days ago)
Milestone	2
Patch	No

11/13/2011 12:26:38 AM	Chuck Hagenbuch	Comment #6 State ⇒ Rejected	Reply to this comment
Folders are going away. Closing.

01/15/2009 04:49:11 AM	Chuck Hagenbuch	Milestone ⇒ 2

06/26/2008 02:19:54 PM	Jan Schneider	Comment #5	Reply to this comment
If designed properly, the Horde 3.2.1 Share drivers would simply ignore the parameter and return an error if we try to delete a folder which contains subfolders. 3.2.2 drivers can do the recursive deletion. Yea. Good point. I guess we could also put a not-as-efficient recursive delete in Trean as well to keep the behavior consistent, if the Share driver returns the error. No, better not. That would only be required for BC for one or two Horde releases. That's not worth it. Plus, if there really is an error deleting folders and you try to do it recursively in Trean, you would probably end up with an error message for each folder, which could be a lot. Also, I think I'd be more comfortable if there was an additional confirmation, or at the least, tweak the text of the existing confirmation to indicate your about to possibly nuke more than you realize. Yes.

06/26/2008 01:38:52 PM	Michael Rubinsky	Comment #4	Reply to this comment
If designed properly, the Horde 3.2.1 Share drivers would simply ignore the parameter and return an error if we try to delete a folder which contains subfolders. 3.2.2 drivers can do the recursive deletion. Yea. Good point. I guess we could also put a not-as-efficient recursive delete in Trean as well to keep the behavior consistent, if the Share driver returns the error. Also, I think I'd be more comfortable if there was an additional confirmation, or at the least, tweak the text of the existing confirmation to indicate your about to possibly nuke more than you realize.

06/26/2008 01:29:55 PM	Jan Schneider	Comment #3	Reply to this comment
If designed properly, the Horde 3.2.1 Share drivers would simply ignore the parameter and return an error if we try to delete a folder which contains subfolders. 3.2.2 drivers can do the recursive deletion.

06/26/2008 01:23:54 PM	Michael Rubinsky	Comment #2	Reply to this comment
Just as a note, this should probably be done along with moving Trean to the native hierarchical SQL driver. Although currently the share driver will refuse to delete any shares with children (as did the original hierarchical DT share driver), we should allow Trean to either recursively delete each share or allow the share driver to take a new parameter which would allow it to ignore children. The second choice would be more efficient, but would mean that Trean would require Horde 3.2.2. If we let it require 3.2.2, then Ansel could also make use of the same functionality since it, too will not delete galleries that contain any non-empty subgalleries. Thoughts?

06/26/2008 10:26:34 AM	Jan Schneider	Milestone ⇒ 1

06/26/2008 10:26:22 AM	Jan Schneider	State ⇒ Accepted Priority ⇒ 2. Medium

06/20/2008 02:53:34 PM	felix (dot) leimbach (at) gmx (dot) net	Comment #1 Milestone ⇒ State ⇒ New Patch ⇒ No Queue ⇒ Trean Summary ⇒ recursive delete Type ⇒ Enhancement Priority ⇒ 1. Low	Reply to this comment
Trean currently refuses to delete folders which have children. This behaviour is inconvenient at times. It even can be a real problem when a large bookmark collection has been imported in a test-run and should be deleted again.