Sat, 22 Nov 2008 11:15:06 -0500 http://bugs.horde.org/ticket/6860 No more support for "pam_auth" extension? Hello, PAM authentification was rewriting to use "pam" instead of "pam_auth" extension. It breaks upgrade path (I had only "pam_auth" extension and after upgrading I can't login to Horde...). Is it possible to support "pam" *and* "pam_auth" extensions? Note: In Debian, we have only "pam_auth" extension for now and anyway, I will break Etch->Lenny upgrades. Regards, -- Gregory Colpart Sun, 08 Jun 2008 10:13:57 -0400 http://bugs.horde.org/ticket/6860#t46092 See this email thread: http://lists.horde.org/archives/dev/Week-of-Mon-20080519/023017.html Note that no one responded to me. Sun, 08 Jun 2008 11:56:19 -0400 http://bugs.horde.org/ticket/6860#t46096 > See this email thread: > http://lists.horde.org/archives/dev/Week-of-Mon-20080519/023017.html > > Note that no one responded to me. pam_auth and pam extensions are different softwares. pam_auth seems to be unmaintained (URL for pam_auth is now 404) but is always in Debian. I propose you this patch (I will perhaps use it in Debian package): http://gcolpart.evolix.net/debian/horde3/pam.php.diff Regards, -- Gregory Colpart Sun, 08 Jun 2008 12:45:54 -0400 http://bugs.horde.org/ticket/6860#t46097 &$error in that call will cause a php notice. Otherwise looks ugly but okay. I'd propose checking for the pam_auth function instead of the extension, and trying to load either extension if it's not already defined. Mon, 09 Jun 2008 21:47:39 -0400 http://bugs.horde.org/ticket/6860#t46152 > &$error in that call will cause a php notice. Otherwise looks ugly > but okay. I'd propose checking for the pam_auth function instead of > the extension, and trying to load either extension if it's not > already defined. Here is the second proposition of my hack with function_exists(): http://gcolpart.evolix.net/debian/horde3/pam.php.2.diff For the change "s/$error/&$error/", the reason is I can't login with "$error" and I have this error message when logging: Warning: Error variable must be passed by reference in /usr/share/horde3/lib/Horde/Auth/pam.php on line 84 Sat, 14 Jun 2008 10:48:34 -0400 http://bugs.horde.org/ticket/6860#t46457 > For the change "s/$error/&$error/", the reason is I can't login with "$error" and I have this error message when logging: > > Warning: Error variable must be passed by reference in > /usr/share/horde3/lib/Horde/Auth/pam.php on line 84 With what PHP version? Sat, 14 Jun 2008 23:30:25 -0400 http://bugs.horde.org/ticket/6860#t46489 >> For the change "s/$error/&$error/", the reason is I can't login with "$error" and I have this error message when logging: >> >> Warning: Error variable must be passed by reference in >> /usr/share/horde3/lib/Horde/Auth/pam.php on line 84 > > With what PHP version? I use PHP 5.2.6 (CGI binary from Debian unstable packages). Sun, 15 Jun 2008 04:51:28 -0400 http://bugs.horde.org/ticket/6860#t46490 Do you have call_time_pass_by_referenced turned on in php.ini? This feature/syntax has been deprecated and throwing warnings for years and years now. Sun, 15 Jun 2008 14:01:03 -0400 http://bugs.horde.org/ticket/6860#t46503 > Do you have call_time_pass_by_referenced turned on in php.ini? This > feature/syntax has been deprecated and throwing warnings for years > and years now. Yes, I have "allow_call_time_pass_reference = On". It's the default in Debian PHP packages. For Horde, this option must be turned off? If yes, could you add to docs? Anyway, I turned it off and PAM auth stays buggy with the same error message. Sun, 15 Jun 2008 18:00:10 -0400 http://bugs.horde.org/ticket/6860#t46516 > Yes, I have "allow_call_time_pass_reference = On". It's the default > in Debian PHP packages. For Horde, this option must be turned off? If > yes, could you add to docs? No, but Horde has to work with it off, since its the default and has been the default in PHP for years, and will stop working at some point in the future. > Anyway, I turned it off and PAM auth stays buggy with the same error message. Which one? Sun, 15 Jun 2008 19:34:59 -0400 http://bugs.horde.org/ticket/6860#t46519 >> Yes, I have "allow_call_time_pass_reference = On". It's the default >> in Debian PHP packages. For Horde, this option must be turned off? If >> yes, could you add to docs? > > No, but Horde has to work with it off, since its the default and has > been the default in PHP for years, and will stop working at some > point in the future. The problem is the extension code, which seems to expect the variable to be passed by reference. This is really old, buggy code. Mon, 16 Jun 2008 03:11:51 -0400 http://bugs.horde.org/ticket/6860#t46540 >> Anyway, I turned it off and PAM auth stays buggy with the same error message. > > Which one? I can't login and I see this error message: Warning: Error variable must be passed by reference in /usr/share/horde3/lib/Horde/Auth/pam.php on line 84 If I change "s/$error/&$error/", all is right. Mon, 16 Jun 2008 03:13:31 -0400 http://bugs.horde.org/ticket/6860#t46541 > If I change "s/$error/&$error/", all is right. No, see Jan's comment. Mon, 16 Jun 2008 10:38:54 -0400 http://bugs.horde.org/ticket/6860#t46561 Actually yes. This old extension code probably *requires* to pass the argument by reference. Mon, 16 Jun 2008 11:07:09 -0400 http://bugs.horde.org/ticket/6860#t46567 I guess. Mon, 16 Jun 2008 11:07:19 -0400 http://bugs.horde.org/ticket/6860#t46568 Since pam_auth is pretty much _only_ now available in debian, is there a real reason to have this in the main Horde dist as opposed to in the debian packages? Wed, 02 Jul 2008 17:26:15 -0400 http://bugs.horde.org/ticket/6860#t47127 Let's remove it for Horde 4. Wed, 02 Jul 2008 18:16:05 -0400 http://bugs.horde.org/ticket/6860#t47131 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Auth/Auth/pam.php?r1=1.21&r2=1.22&ty=u Sun, 13 Jul 2008 08:48:56 -0400 http://bugs.horde.org/ticket/6860#t47495