<?xml version="1.0" encoding="ISO-8859-1"?> 
<?xml-stylesheet href="http://bugs.horde.org/themes/feed-rss.xsl" type="text/xsl"?> 
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom"> 
 <channel> 
  <title>Viewing Inline HTML vs text message as user settable option</title> 
  <pubDate>Thu, 18 Mar 2010 12:57:03 -0400</pubDate> 
  <link>http://bugs.horde.org/ticket/6711</link> 
  <atom:link rel="self" type="application/rss+xml" title="Viewing Inline HTML vs text message as user settable option" href="http://bugs.horde.org/ticket/6711/rss" /> 
  <description>Viewing Inline HTML vs text message as user settable option</description> 
 
   
   
  <item> 
   <title>I am currently modifying the prefs.php and mime_drivers.php </title> 
   <description>I am currently modifying the prefs.php and mime_drivers.php files to add the ability to give users the choice of viewing messages in HTML or text by default as a preference option.



Has the Horde team looked at adding this as a user settable option if inline HTML and text are being permitted (and a message has both formats being sent in message)? 



Can this be added as a request for future releases? </description> 
   <pubDate>Thu, 15 May 2008 18:49:45 -0400</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t45304</link> 
  </item> 
   
  <item> 
   <title>Makes sense.</title> 
   <description>Makes sense.</description> 
   <pubDate>Fri, 16 May 2008 05:13:57 -0400</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t45308</link> 
  </item> 
   
  <item> 
   <title>You said you were modifying files for this - can you submit </title> 
   <description>You said you were modifying files for this - can you submit a patch?</description> 
   <pubDate>Wed, 05 Nov 2008 21:19:29 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t50324</link> 
  </item> 
   
  <item> 
   <title>&gt; You said you were modifying files for this - can you submi</title> 
   <description>&gt; You said you were modifying files for this - can you submit a patch?



I can tell you what I did as its not that difficult.  In mime_drivers.php I added an if statment and changed the boolean value to be a variable name:





if ( $GLOBALS['prefs']-&gt;getValue('html_inline_viewing') === '0' ) {

        $viewHtmlInline = false;

} else {

        $viewHtmlInline = true;

}





/**

 * HTML driver settings

 */

$mime_drivers['imp']['html'] = array(

    'inline' =&gt; $viewHtmlInline,





and created a new preference in prefs.php:



$_prefs['html_inline_viewing'] = array (

	'value' =&gt; 1,

	'locked' =&gt; false,

	'shared' =&gt; false,

	'type' =&gt; 'checkbox',

	'desc' =&gt; _(&quot;View messages as HTML when both HTML and plain text are available (this change takes effect after log out)?&quot;),

	'help' =&gt; 'prefs-notavailable'

);</description> 
   <pubDate>Thu, 06 Nov 2008 11:22:29 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t50408</link> 
  </item> 
   
  <item> 
   <title>PS, I am sure there is a better way to do this and am hoping</title> 
   <description>PS, I am sure there is a better way to do this and am hoping the horde team can do it better than my hack of a solution.</description> 
   <pubDate>Thu, 06 Nov 2008 11:23:43 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t50409</link> 
  </item> 
   
  <item> 
   <title>Should this really be user settable?  This implicates both s</title> 
   <description>Should this really be user settable?  This implicates both security and server load concerns (XSS/Phishing filtering is not cheap) and seems to be better left to the discretion of an admin.</description> 
   <pubDate>Wed, 09 Dec 2009 18:36:54 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t57095</link> 
  </item> 
   
  <item> 
   <title>We should lock the preference by default, so that it mimics </title> 
   <description>We should lock the preference by default, so that it mimics the current behavior of the mime_drivers.php setting.</description> 
   <pubDate>Wed, 09 Dec 2009 19:19:08 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t57100</link> 
  </item> 
   
  <item> 
   <title>I still don't agree with this.  I don't want the same config</title> 
   <description>I still don't agree with this.  I don't want the same configuration option appearing in 2 different locations: mime_driver config needs to stay in the mime_driver config files where everything else about that driver is configured.</description> 
   <pubDate>Tue, 15 Dec 2009 15:41:25 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t57188</link> 
  </item> 
   
  <item> 
   <title>That's a good point, it would indeed make the configuration </title> 
   <description>That's a good point, it would indeed make the configuration a bit confusing.</description> 
   <pubDate>Tue, 15 Dec 2009 16:53:50 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t57193</link> 
  </item> 
   
  <item> 
   <title>I'm going to reject.  Maybe in the future there will be some</title> 
   <description>I'm going to reject.  Maybe in the future there will be some Horde_Prefs_Ui way to interact with mime_drivers.php settings.</description> 
   <pubDate>Tue, 15 Dec 2009 23:35:22 -0500</pubDate> 
   <link>http://bugs.horde.org/ticket/6711#t57199</link> 
  </item> 
   
   
 
 </channel> 
</rss> 
