Vacation and forward conflict in SunOne LDAP schema

I would like to explain a problem that affect all people tha

Fri, 09 May 2008 07:12:15 +0000

I would like to explain a problem that affect all people that use forward and vacation modules together with LDAP driver. In SunOne schema vacation and forward mechanism use the same attribute "maildeliveryoption". So, if a user set vacation lose forward setting, and vice versa. Because if I set a module I change maildeliveryoption not only on interested value, but rewriting all its values. Let me explain with an example: Let be that attribute which contains the vacation status and forward status is the same: maildeliveryoption. A user set a forward: ldap driver set maildeliveryoption adding "forward" value. Then the same user also set vacation: ldap vacation driver instead to *add* "autoreply" value to maildeliveryoption, *replace* it with "autoreply" value. So user lose the "forward" value previously set. See also http://bugs.horde.org/ticket/6523 I know that this should be a particular condition of SunOne, but all environments that use same multivalued attribute to set vacation and forward could be affected. It is also true that these LDAP drivers should only modify single value of multivalued attribute, instead of replacing attribute at all, without preserve other values. What do you think? A fix to this behavior should be very appreciate. I thank you very much Best Regards

This isn't totally unique to LDAP. If you use the .forward

Fri, 09 May 2008 16:54:13 +0000

This isn't totally unique to LDAP. If you use the .forward setup for vacation and forwards, they also overwrite eachother since they use the same .forward file and don't really know about each other (as well as any other uses of the .forward file). To fix this, you would need "intellegent" parsing of the contents of the field/file/etc so as to "update" it intellegently rather than simply replacing or removing the contents. Doing such work reliably may be problematic depending on the contents of the field and how it can be updated by other sources, etc. Maybe it is better to focus on Ingo for such advanced settings, rather than continuing such complex work on Sork? IMHO, in order to implement the requested feature, we would need to know all possible values of maildeliveryoption and what the syntax of the contents is. Then build something which understands that syntax and knows the options, and can manipulate them in a safe way. Doing that for LDAP is probably much easier than for a .forward file, but you still never know if some other software might use the maildeliveryoption in a non-standard way or something.

I would try to explain better about LDAP. I don't think it i

Tue, 13 May 2008 12:17:21 +0000

I would try to explain better about LDAP. I don't think it is necessary to know all possible values of attribute used by forward/vacation. It's only necessary that driver acts only on values related to working mechanism. For instance, If vacation module set attribute maildeliveryoption to "autoreply", when I unset vacation, driver should only delete value "autoreplay" of maildeliveryoption, leaving other values unchanged. "ldap_mod_del" permits deletion of single attribute value, I suppose. At the same, I could add value to attribute leaving its other values unchanged. I apologize if I don't explain better. Thank again Regards

I have written a little patch to ldap driver which let vacat

Thu, 18 Sep 2008 08:24:32 +0000

I have written a little patch to ldap driver which let vacation works without interfering forward module. But a new driver (named SunOneLDAPMessaging or something analog) should be done. Also, ldap attribute vacationEndDate, vacationStartDate and mailAutoReplyTimeout could be added. With minimum changes I done, $conf[server][params][default][disabled] is only the value that must always exists in a mailbox account. Vacation is activated and disabled managing a single value. Similar changes should be done to forward SunOne module... To view behavior is sufficient to patch ldap driver as follow: diff ldap.php.orig ldap.php 222d221 < $newDetails[$this->_params[$realm]['active']] = explode("|", $this->_params[$realm]['enabled']); 226,227d224 < $this->_disconnect(); < return false; 228a226,237 > unset($newDetails); // $message was already replaced > $_ = explode("|", $this->_params[$realm]['enabled']); > foreach ( $_ as $value ) > $newDetails[$this->_params[$realm]['active']][] = $value; > $res = ldap_mod_add($this->_ds, $userdn, $newDetails); > if (!$res) { > $res = PEAR::raiseError(ldap_error($this->_ds)); > $this->_disconnect(); > return false; > } > > 349a359,364 > if (in_array($this->_params[$realm]['enabled'],$retAttrs[$vacationAttr])) > $retAttrs[$vacationAttr] = array($this->_params[$realm]['enabled']); > else { > if (in_array($this->_params[$realm]['disabled'],$retAttrs[$vacationAttr])) > $retAttrs[$vacationAttr] = array($this->_params[$realm]['disabled']); > } 398,399c413,414 < $newDetails[$this->_params[$realm]['active']] = $this->_params[$realm]['disabled']; < $result = ldap_mod_replace($this->_ds, $userdn, $newDetails); --- > $newDetails[$this->_params[$realm]['active']][] = $this->_params[$realm]['enabled']; > $result = ldap_mod_del($this->_ds, $userdn, $newDetails);

this is same patch in a file attachment

Thu, 18 Sep 2008 08:27:25 +0000

this is same patch in a file attachment

I add the same driver patched for Messaging Server based on

Fri, 08 May 2009 12:03:56 +0000

I add the same driver patched for Messaging Server based on last vacation version (3.1). Original ldap driver doesn't work for Sun Messaging. In this last vacation version I had also to modify new Driver.php in function isEnabled: // Check vacation flag. if ($current_details['vacation'] == 'y' || $current_details['vacation'] == 'Y' || $current_details['vacation'] == $this->_params[$this->_realm]['enabled']) { return 'Y'; } elseif ($current_details['vacation'] == 'n' || $current_details['vacation'] == 'N' || $current_details['vacation'] == $this->_params[$realm]['disabled']) { return 'N'; } else { return false; }

Please provide this as a patch.

Tue, 12 May 2009 14:28:13 +0000

Please provide this as a patch.

> Please provide this as a patch. I added two file: pa

Wed, 13 May 2009 07:21:48 +0000

> Please provide this as a patch. I added two file: patch_Driver.txt for vacation/lib/Driver.php patch_ldap.txt for vacation/lib/Driver/ldap.php Vacation version is the last (3.1). I hope this help...

Wed, 13 May 2009 07:22:31 +0000

It would be even better if you made it a single unified diff

Thu, 14 May 2009 17:19:26 +0000

It would be even better if you made it a single unified diff.

I attach a unified patch for the two file modified.

Fri, 15 May 2009 06:18:21 +0000

I attach a unified patch for the two file modified.

This is the final right file: patchVacation.txt

Fri, 15 May 2009 06:20:58 +0000

This is the final right file: patchVacation.txt

Thank you for testing with the SunOne Directory Server. I w

Mon, 18 May 2009 14:45:42 +0000

Thank you for testing with the SunOne Directory Server. I was unable to test since I do not have access to one. I am reviewing your patch and will update the ticket when I have reviewed it in my test environment.