Replace vfs-direct with X-Sendfile support Tue, 07 Oct 2008 04:50:38 -0400 http://bugs.horde.org/ticket/6411 Replace vfs-direct with X-Sendfile support From Jan: How about deprecating vfs-direct in Ansel for X-S From Jan: How about deprecating vfs-direct in Ansel for X-Sendfile support? http://tn123.ath.cx/mod_xsendfile/ Works with both Apache and Lighttpd, fixes the permissions problem, and the admins don't have to do much more configuration than with the vfs-direct feature. Sun, 09 Mar 2008 00:37:57 -0500 http://bugs.horde.org/ticket/6411#t43606 ...although just a note that mod_xsendfile for Apache is 2.x ...although just a note that mod_xsendfile for Apache is 2.x only. Sun, 09 Mar 2008 00:39:17 -0500 http://bugs.horde.org/ticket/6411#t43607 It's also more flexible than vfs-direct, since we can use it It's also more flexible than vfs-direct, since we can use it anytime it's more efficient to get a local file out of the VFS - with the FTP backend, for example. I have some ideas on API changes to VFS for this and then BC-compatible ways to use them in Ansel, Gollem, maybe IMP too. Sun, 09 Mar 2008 00:41:35 -0500 http://bugs.horde.org/ticket/6411#t43608 Would it still be worth keeping vfs-direct as an option thou Would it still be worth keeping vfs-direct as an option though for those sites that are OK with allowing it? For Ansel, at least, it would save having to load an Ansel_Image object from the database just to get the VFS path to send with X-Sendfile header... Sun, 09 Mar 2008 18:06:36 -0400 http://bugs.horde.org/ticket/6411#t43626 Which is good because it allows us to check permissions. If Which is good because it allows us to check permissions. If we could shortcircuit permission checking even better, but at the moment permissions aren't checked at all. I don't know if we deem security by obscurity through hard to guess path/file names sufficient. Mon, 10 Mar 2008 04:43:42 -0400 http://bugs.horde.org/ticket/6411#t43644 Yep, exactly. What I'm suggesting is to keep it as an *opti Yep, exactly. What I'm suggesting is to keep it as an *option*, in addition to the X-Sendfile, for those sites that are OK with the photos being accessible without permissions checking. If not, I don't feel strongly about it. It was just a thought. Mon, 10 Mar 2008 10:34:36 -0400 http://bugs.horde.org/ticket/6411#t43651 Chuck, assigning to you since you said you had VFS api chang Chuck, assigning to you since you said you had VFS api changes to support this... you can kick it back to me if I am mistaken :) Sat, 15 Mar 2008 16:42:39 -0400 http://bugs.horde.org/ticket/6411#t43857 Done. You can use the new VFS::readFile() method to get a lo Done. You can use the new VFS::readFile() method to get a local file for use with x-sendfile. With the file backend it'll just return the local filename - a much cleaner solution for vfs-direct that should be just about as fast. Sat, 17 May 2008 23:37:41 -0400 http://bugs.horde.org/ticket/6411#t45339 Done Done Wed, 21 May 2008 16:53:46 -0400 http://bugs.horde.org/ticket/6411#t45450