6.0.0-alpha12
6/8/25

[#6395] Prefs singleton method does not check scope
Summary Prefs singleton method does not check scope
Queue Horde Groupware Webmail Edition
Queue Version 1.1-RC2
Type Bug
State Resolved
Priority 2. Medium
Owners chuck (at) horde (dot) org
Requester janne.peltonen (at) helsinki (dot) fi
Created 03/07/2008 (6302 days ago)
Due
Updated 03/10/2008 (6299 days ago)
Assigned 03/07/2008 (6302 days ago)
Resolved 03/10/2008 (6299 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
03/10/2008 07:01:18 PM Chuck Hagenbuch Comment #4
State ⇒ Resolved
Reply to this comment
Committed, thanks for testing.
03/10/2008 06:41:53 PM Chuck Hagenbuch Deleted Original Message
 
03/10/2008 08:15:10 AM janne (dot) peltonen (at) helsinki (dot) fi Comment #3 Reply to this comment
Seems to work for me. Thanks.
03/07/2008 09:04:24 PM Chuck Hagenbuch Comment #2
New Attachment: Prefs.diff.txt Download
State ⇒ Feedback
Assigned to Chuck Hagenbuch
Reply to this comment
Can you try the attached patch instead? We can cache objects with 
different scopes (and we want to, really, to avoid re-doing work), we 
just need to reset the scope.
03/07/2008 11:11:54 AM janne (dot) peltonen (at) helsinki (dot) fi Comment #1
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Prefs singleton method does not check scope
Queue ⇒ Horde Groupware Webmail Edition
New Attachment: prefs_singleton_fix.patch
State ⇒ Unconfirmed
Reply to this comment
Apparently the Prefs class singleton method does not include the scope 
of the Prefs instance into the signature of the instance. This causes 
trouble at least with ingo/scripts/convert_imp_filters.php which first 
causes a Prefs object of scope 'imp' to be created (in order to load 
the 'filters' preference) and then, while wanting to save the 
converted filters in scope 'ingo' fails - because ingo_storage tries 
to get the singleton Prefs object and gets the one of type 'imp' - 
which has no 'rules' nor 'blacklist' etc. preferences. Attached patch 
adds scope to the signature of the singleton Prefs object - 
convert_imp_filters.php works after this, but does something else break?

Saved Queries