Sat, 05 Jul 2008 20:07:09 -0400 http://bugs.horde.org/ticket/6377 recurrence end date / fix off-by-one-day issue in kronolith/lib/Recurrence.php there were some marks pointing at an off-by-one-day issue. reproduce it: use the kolab driver. create a (kolab) event (20th of march), define daily recurrence and also define an end date for recurrence (30th of march). in kronolith the last entry in the calendar will be on the 29th. recurrency ends on the 30th march at 0:00am. in kolab xml events you can obviously only store date-only hashes for recur end date (not time component). at least, this is what the new/XML kolab driver in horde does... my fix for this issues does the following. it adds some hours and minutes to the recur end date (23:59h) and then the last event of the recurrence is displayed correctly. --- a/kronolith/lib/Recurrence.php 2007-11-29 12:33:10.000000000 +0000 +++ b/kronolith/lib/Recurrence.php 2008-03-05 16:26:28.000000000 +0000 @@ -1156,10 +1156,8 @@ break; case 'date': - // fix off-by-one day - //FIXME $timestamp = Kolab_Date::decodeDate($hash['range']); - $this->setRecurEnd(new Horde_Date($timestamp + 86400)); + $this->setRecurEnd(new Horde_Date($timestamp + 86340)); break; } @@ -1352,10 +1350,7 @@ $hash['range-type'] = 'number'; $hash['range'] = $this->getRecurCount(); } elseif ($this->hasRecurEnd()) { - // Fix of-by-one day. $date = $this->getRecurEnd(); - $date->mday -= 1; - $date->correct(); $hash['range-type'] = 'date'; $hash['range'] = Kolab_Date::encodeDate($date->timestamp()); } else { Wed, 05 Mar 2008 12:05:50 -0500 http://bugs.horde.org/ticket/6377#t43403 i guess this should also go into lib/Horde/Date/Recurrence.php Wed, 05 Mar 2008 12:46:07 -0500 http://bugs.horde.org/ticket/6377#t43405 Jan put those fixme comments in there, so I'm passing this one to him. Thanks! Wed, 05 Mar 2008 17:25:24 -0500 http://bugs.horde.org/ticket/6377#t43413 hi , gone through my bug report history. this actually a follow up of http://bugs.horde.org/ticket/?id=6265 mike Mon, 10 Mar 2008 14:46:31 -0400 http://bugs.horde.org/ticket/6377#t43670 Both Gunnar's original code and your fix didn't look correct to me, please try what I committed. Sat, 17 May 2008 16:47:27 -0400 http://bugs.horde.org/ticket/6377#t45327 Ping? Fri, 23 May 2008 15:17:21 -0400 http://bugs.horde.org/ticket/6377#t45502 Going to guess this is fixed for now. Sun, 25 May 2008 15:11:05 -0400 http://bugs.horde.org/ticket/6377#t45588