Tickets :: [#6101] Move gallery attributes from datatree

Summary	Move gallery attributes from datatree
Queue	Ansel
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	Michael Rubinsky <mrubinsk (at) horde (dot) org>
Requester	Michael Rubinsky <mrubinsk (at) horde (dot) org>
Created	01/10/2008 (279 days ago)
Due
Updated	01/15/2008 (274 days ago)
Assigned
Resolved	01/15/2008 (274 days ago)
Attachments	2008_01_07_add_galleries.sql 2008_01_07_sql_galleries[1].php BigAnselPatch[1].diff
Milestone
Patch	No

01/15/2008	Michael Rubinsky	Comment #7 State ⇒ Resolved	Reply to this comment
Committed directly to HEAD. I've been running this code on a dev server for about a week now with light family usage and I'm fairly confident there are no overt errors. Hope that didn't just jinx me...

01/15/2008	Jan Schneider	Comment #6	Reply to this comment
Wow, that's a huge diff. :) But the changes look pretty straight forward, and I would say, go and commit it. If you feel more confident stabilizing it in CVS first, before letting it go to the masses, you could commit it to a branch.

01/15/2008	Jan Schneider	Deleted Attachment: 2008_01_07_sql_galleries.php

01/15/2008	Jan Schneider	Deleted Attachment: BigAnselPatch.diff

01/14/2008	Michael Rubinsky	Comment #5 New Attachment: BigAnselPatch[1].diff	Reply to this comment
Finally got through all the cvs conflicts after updating to HEAD one last time. This patch should now apply cleanly to current CVS code. There is still more to do, but I wanted to get input on the general design and get this into CVS before I make more changes...

01/11/2008	Michael Rubinsky	Comment #4 New Attachment: 2008_01_07_sql_galleries[1].php	Reply to this comment
Sorry, uploaded an older version of the upgrade script. This is the correct one. One more reason I want to get this into CVS ;)

01/10/2008	Chuck Hagenbuch	Summary ⇒ Move gallery attributes from datatree

01/10/2008	Michael Rubinsky	Comment #3 New Attachment: 2008_01_07_add_galleries.sql Summary ⇒ Move gallery attributes out of datatree	Reply to this comment
add the gallery table

01/10/2008	Michael Rubinsky	Comment #2 New Attachment: 2008_01_07_sql_galleries.php Assigned to Michael Rubinsky	Reply to this comment
The upgrade script

01/10/2008	Michael Rubinsky	Comment #1 New Attachment: BigAnselPatch.diff Queue ⇒ Ansel Summary ⇒ Remove gallery attributes out of datatree Type ⇒ Enhancement Priority ⇒ 1. Low State ⇒ Feedback	Reply to this comment
Alright, here goes. First patch for removing gallery attributes from DT. In a nutshell, Horde_Share is still used for permissions and for gallery hierarchy. New class Ansel_Storage contains most DB related code (still some sprinkled around Ansel.php and Tags.php) and is resposible for creating a properly scoped Ansel_Share object. Also contains all get/list type methods that client code interacts with. The existing Ansel_Gallery class has been renamed to Ansel_Gallery_Share and a new Ansel_Gallery object has been added...all client code interacts with the Ansel_Gallery object and if needed, it delegates to the Ansel_Gallery_Share object.. Probably more confusing to try to explain it...so attached are the various patches. Just a not about the upgrade script - it does add one new attribute to existing datatree gallery structure, but does not delete any of the data that has been moved to the new structure....I'll probably put that into another upgrade script that should be run after the first upgrade has been successful to ease in rolling back if needed.