[#5937] smbldap driver: don't update commented attributes
| Summary | smbldap driver: don't update commented attributes |
| Queue | Passwd |
| Queue Version | 3.0.1 |
| Type | Enhancement |
| State | Resolved |
| Priority | 1. Low |
| Owners | Chuck Hagenbuch <chuck (at) horde (dot) org> |
| Requester | fabio (dot) pedretti (at) ing (dot) unibs (dot) it |
| Created | 11/29/2007 (164 days ago) |
| Due | |
| Updated | 11/30/2007 (163 days ago) |
| Assigned | |
| Resolved | 11/30/2007 (163 days ago) |
| Attachments | backends.php.dist.patch  smbldap.php.patch |
| Milestone | |
| Patch |
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Committed, thanks!New Attachment: backends.php.dist.patch
Also attached a documentation patch for backends.php.dist .State ⇒ Feedback
This looks good to me - I'll commit it in a bit if no one has any objections/sees any problems with it.New Attachment: smbldap.php.patch
A patch form smbldap.php is attached.
It also fixes a possible minor problem, where if pw_expire_time was not set in backends.php, it was set to current time + 2147483647 * 86400. However seems [1] that 2147483647 is the maximux NT time already in seconds (would be nice if someone with a better understanding of samba/windows could confirm).
[1] http://lists.samba.org/archive/samba/2004-January/078175.html
Queue ⇒ Passwd
Type ⇒ Enhancement
State ⇒ New
Summary ⇒ smbldap driver: don't update commented attributes
Priority ⇒ 1. Low
In my LDAP tree I have only sambaLMPassword and sambaNTPassword, but not sambaPwdLastSet and sambaPwdMustChange (I need these password hashes for FreeRADIUS).
If an attribute in config/backends.php is commented would be nice to not set it in the LDAP. So I could comment:
# 'pw_set_attribute' => 'sambaPwdLastSet',
# 'pw_expire_attribute' => 'sambaPwdMustChange',
# 'pw_expire_time' => 180, // number of days until samba password expires
and these won't be updated.
Ideally, smbldap and ldap should be the same driver, where one can enable only the needed attributes.