[#5923] Use Text_Flowed for quoting and displaying ticket replies
Summary Use Text_Flowed for quoting and displaying ticket replies
Queue Whups
Type Enhancement
State Resolved
Priority 1. Low
Owners Jan Schneider <jan (at) horde (dot) org>
Requester Chuck Hagenbuch <chuck (at) horde (dot) org>
Created 11/25/2007 (222 days ago)
Due
Updated 06/24/2008 (10 days ago)
Assigned 06/12/2008 (22 days ago)
Resolved 06/24/2008 (10 days ago)
Attachments
Milestone
Patch No

History
06/24/2008 Jan Schneider State ⇒ Resolved
 
06/12/2008 Jan Schneider Comment #14
State ⇒ Assigned		 Reply to this comment
Also, the quoted bits are still hard-wrapped in email notifications also.
Yes, but reflowed, so that the quotes levels are not broken. As I 
said, the wrapping happens during the quoting, and the result is used 
for both emails, and storing in the backend.
06/12/2008 Jan Schneider Comment #13 Reply to this comment
While we're at it, using the highlightquotes filter would be nice. :)
This will be added in the next few days.
06/12/2008 Chuck Hagenbuch Comment #12 Reply to this comment
Also, the quoted bits are still hard-wrapped in email notifications also.
06/12/2008 Chuck Hagenbuch Comment #11 Reply to this comment
It's just a poor use of space when displaying comments - if we can 
flow quoted text in IMP, we should be able to do it in whups.

While we're at it, using the highlightquotes filter would be nice. :)
06/12/2008 Jan Schneider Comment #10 Reply to this comment

Yes - try replying to a comment. I'm not sure about the generated
email, since it's currently empty for me, but in the Whups UI, the
quoted text is still hard-wrapped at 80 cols.
Trying with this very comment, as Whups is up-to-date on
bugs.horde.org now. Btw, I thought the ticket was only about the
email notifications, and not the Whups UI, so I didn't even look at
that.
Okay, I see your point now. I never considered this a problem, as
long as the lines don't wrap inside a quoted text, and that shouldn't
happen anymore.
Trying to add more indention, to force one more wrap.
More indention.
Looks like it's wrapped during the quoting only anyway.
06/12/2008 Jan Schneider Comment #9 Reply to this comment

Yes - try replying to a comment. I'm not sure about the generated
email, since it's currently empty for me, but in the Whups UI, the
quoted text is still hard-wrapped at 80 cols.
Trying with this very comment, as Whups is up-to-date on
bugs.horde.org now. Btw, I thought the ticket was only about the
email notifications, and not the Whups UI, so I didn't even look at
that.
Okay, I see your point now. I never considered this a problem, as
long as the lines don't wrap inside a quoted text, and that shouldn't
happen anymore.
Trying to add more indention, to force one more wrap.
More indention.
06/12/2008 Jan Schneider Comment #8 Reply to this comment

Yes - try replying to a comment. I'm not sure about the generated
email, since it's currently empty for me, but in the Whups UI, the
quoted text is still hard-wrapped at 80 cols.
Trying with this very comment, as Whups is up-to-date on
bugs.horde.org now. Btw, I thought the ticket was only about the
email notifications, and not the Whups UI, so I didn't even look at
that.
Okay, I see your point now. I never considered this a problem, as
long as the lines don't wrap inside a quoted text, and that shouldn't
happen anymore.
Trying to add more indention, to force one more wrap.
06/12/2008 Jan Schneider Comment #7 Reply to this comment

Yes - try replying to a comment. I'm not sure about the generated
email, since it's currently empty for me, but in the Whups UI, the
quoted text is still hard-wrapped at 80 cols.
Trying with this very comment, as Whups is up-to-date on
bugs.horde.org now. Btw, I thought the ticket was only about the
email notifications, and not the Whups UI, so I didn't even look at
that.
Okay, I see your point now. I never considered this a problem, as long 
as the lines don't wrap inside a quoted text, and that shouldn't 
happen anymore.
06/12/2008 Jan Schneider Comment #6 Reply to this comment
Yes - try replying to a comment. I'm not sure about the generated
email, since it's currently empty for me, but in the Whups UI, the
quoted text is still hard-wrapped at 80 cols.
Trying with this very comment, as Whups is up-to-date on 
bugs.horde.org now. Btw, I thought the ticket was only about the email 
notifications, and not the Whups UI, so I didn't even look at that.
06/12/2008 Chuck Hagenbuch Comment #5
State ⇒ Accepted		 Reply to this comment
Yes - try replying to a comment. I'm not sure about the generated 
email, since it's currently empty for me, but in the Whups UI, the 
quoted text is still hard-wrapped at 80 cols.
06/12/2008 Jan Schneider Comment #4
State ⇒ Feedback		 Reply to this comment
I had fixed that with two later commits. Did you update both MIME and Whups?
06/12/2008 Chuck Hagenbuch Comment #3
State ⇒ Accepted		 Reply to this comment
Not really - when you reply to a comment, the quoted text is still 
hard wrapped. That's the place where this will really make a 
difference imo.
06/11/2008 Jan Schneider Comment #2
State ⇒ Resolved
Assigned to Jan Schneider		 Reply to this comment
MIME_Mail is using Text_Flowed now, so this should be done.
12/13/2007 Jan Schneider State ⇒ Accepted
 
11/25/2007 Chuck Hagenbuch Comment #1
Priority ⇒ 1. Low
State ⇒ New
Type ⇒ Enhancement
Queue ⇒ Whups
Summary ⇒ Use Text_Flowed for quoting and displaying ticket replies		 Reply to this comment
avoid hard wraps in ticket replies