[#5749] A restructured view system with tabs for nag
Summary A restructured view system with tabs for nag
Queue Nag
Queue Version HEAD
Type Enhancement
State Rejected
Priority 1. Low
Owners
Requester Gunnar Wrobel <p (at) rdus (dot) de>
Created 09/27/2007 (282 days ago)
Due
Updated 10/04/2007 (275 days ago)
Assigned
Resolved 10/04/2007 (275 days ago)
Attachments HK-GW-Tabify[1].patch Download
HK-GW-Tabify.patch Download
HK-GW-Tabify[2].patch Download
Milestone
Patch No

History
10/04/2007 Gunnar Wrobel State ⇒ Rejected
 
10/04/2007 Gunnar Wrobel Comment #7 Reply to this comment

Care to explaine "editing truly inline"? :) Maybe you can point out
if there is another app in Horde currently doing it in a way how it
*should* be done so that I can use that as a basis for restructuring.
There is not inline editing that I know of anywhere in Horde. What I
mean by that is having the display view also be the edit view -
whether that means clicking a piece of text to turn it into an input
control, or styling the inputs nicely enough that they look good for
display, either is fine with me.
Yes, this would definitely be nice. I know I'm unable to deliver such 
thing at the moment but maybe I can look at it later - especially when 
I know more about java script :). I'll keep this around as a local 
patch for my work environment at the moment so that I can use 
recurrence in nag. Thanks for  the comments!
10/03/2007 Chuck Hagenbuch Comment #6 Reply to this comment

In any case the main reason for restructuring was that I locally
patched nag for recurrence support in the Kolab driver. For task
recurrence I think you need a dedicated "CompleteTask" view which
would also allow to have more options on tasks with subtasks (e.g.
"Complete task including all subtasks"). In addition I also wanted to
add the quick deletion link so I needed another deletion confirmation
page. Adding two views that currently don't exist was the reason for
restructuring and looking at the UI parts of Horde.
Okay.
Care to explaine "editing truly inline"? :) Maybe you can point out
if there is another app in Horde currently doing it in a way how it
*should* be done so that I can use that as a basis for restructuring.
There is not inline editing that I know of anywhere in Horde. What I 
mean by that is having the display view also be the edit view - 
whether that means clicking a piece of text to turn it into an input 
control, or styling the inputs nicely enough that they look good for 
display, either is fine with me.
09/29/2007 Gunnar Wrobel Comment #5 Reply to this comment
Is there a specific reason you think that this is better?
I had the impression that the code structure in Konolith/Turba was an 
example of how the newer apps should be constructed. I guess I might 
have been mistaken there :)

In any case the main reason for restructuring was that I locally 
patched nag for recurrence support in the Kolab driver. For task 
recurrence I think you need a dedicated "CompleteTask" view which 
would also allow to have more options on tasks with subtasks (e.g. 
"Complete task including all subtasks"). In addition I also wanted to 
add the quick deletion link so I needed another deletion confirmation 
page. Adding two views that currently don't exist was the reason for 
restructuring and looking at the UI parts of Horde.
The tabs in
Krono/Turba were kind of a compromise to spiff things up a bit to
work with DIMP because there wasn't time to make the editing truly
inline. If we're going to spend time on this in Nag, I'd rather do
that.
Care to explaine "editing truly inline"? :) Maybe you can point out if 
there is another app in Horde currently doing it in a way how it 
*should* be done so that I can use that as a basis for restructuring.

Thanks for you comments!
09/28/2007 Chuck Hagenbuch Comment #4
State ⇒ Feedback
Reply to this comment
Is there a specific reason you think that this is better? The tabs in 
Krono/Turba were kind of a compromise to spiff things up a bit to work 
with DIMP because there wasn't time to make the editing truly inline. 
If we're going to spend time on this in Nag, I'd rather do that.
09/28/2007 Gunnar Wrobel Comment #3
New Attachment: HK-GW-Tabify[2].patch Download
Reply to this comment
Added missing loadChildren() call when viewing a task.
09/27/2007 Gunnar Wrobel Comment #2
New Attachment: HK-GW-Tabify[1].patch Download
Reply to this comment
Probably not necessary but this updates the patch to the recent CVS changes.
09/27/2007 Gunnar Wrobel Comment #1
New Attachment: HK-GW-Tabify.patch Download
Queue ⇒ Nag
Priority ⇒ 1. Low
Type ⇒ Enhancement
State ⇒ New
Summary ⇒ A restructured view system with tabs for nag
Reply to this comment
This is an attempt to restructure the view code in nag so that it 
supports the "Tab view" used in Turba and Kronolith.

This is only a first draft and one thing not working is the JavaScript 
feature of switching the tabs. I did not understand yet how this works 
:) Anyhow I wanted to submit this early in order to see if it goes 
into the right direction. I'm happy if you point out my mistakes since 
this is my first attempt at getting deeper into the UI aspects of Horde.

Thanks!