Tickets :: [#5641] Creating filter rules with null test values

6.0.0-beta1

7/10/25

Summary	Creating filter rules with null test values
Queue	Ingo
Queue Version	1.1.3
Type	Bug
State	Resolved
Priority	1. Low
Owners	chuck (at) horde (dot) org
Requester	robin.west (at) dal (dot) ca
Created	08/16/2007 (6538 days ago)
Due
Updated	08/22/2007 (6532 days ago)
Assigned	08/22/2007 (6532 days ago)
Resolved	08/22/2007 (6532 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

08/22/2007 04:13:20 AM	Chuck Hagenbuch	Comment #5 State ⇒ Resolved	Reply to this comment
Tweaked.

08/22/2007 03:52:00 AM	Chuck Hagenbuch	State ⇒ Assigned

08/22/2007 03:46:57 AM	Matt Selsky	Comment #4	Reply to this comment
And "doesn't exist" tests.

08/22/2007 03:44:51 AM	Matt Selsky	Comment #3	Reply to this comment
No good. This also rejects "exists" tests...

08/22/2007 03:11:39 AM	Chuck Hagenbuch	Comment #2 Assigned to Chuck Hagenbuch State ⇒ Resolved	Reply to this comment
Definitely sounds like a good idea to me. I've added code to 1.2-cvs (aka HEAD currently) to reject saving of a rule if there are empty conditions in it.

08/16/2007 06:33:19 PM	robin (dot) west (at) dal (dot) ca	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Creating filter rules with null test values Queue ⇒ Ingo State ⇒ Unconfirmed	Reply to this comment
Judging from bugs 3313 and 5392, it sounds like users shouldn't be able to create a filter rule such as "Subject contains <null>". But there doesn't appear to be anything preventing this. In both 1.0.1 and in 1.1.3, users can leave the value field empty and save the filter. We've had several users blow away their inboxes because they inadvertently set up filter rules such as this. Is there supposed to be something preventing them from saving a rule with an empty test value? -Robin