Fri, 29 Aug 2008 20:21:26 -0400 http://bugs.horde.org/ticket/5337 Add browse API call to implement WebDAV read support This patch adds a function, _gollem_browse() to Gollem's API to enable browsing Gollem/VFS shares via WebDAV. Two additional supporting functions are added to the Gollem:: class. If this patch is merged I will also implement the _gollem_put() method to complete WebDAV support (and I believe close a bounty in the process). Note that there is a bug in HTTP_WebDAV_Server which affects any filename containing "+", "%" or any other filename with urlencoded characters. A bug has been filed upstream. Even without this fixed, all files and directories without special characters are handled properly. Mon, 07 May 2007 19:31:13 -0400 http://bugs.horde.org/ticket/5337#t32750 Please use double quotes for the gettext strings, and you can probably save one str_replace() call by using rawurlencode() instead of urlencode(). Tue, 08 May 2007 04:06:18 -0400 http://bugs.horde.org/ticket/5337#t32755 Here is an updated patch with the quotes converted from single to double for gettext. I checked the documentation on rawurlencode() vs. urlencode() but I do not think I see how it would save me any calls? Would you give me another hint? Tue, 08 May 2007 10:07:43 -0400 http://bugs.horde.org/ticket/5337#t32775 > I checked the documentation on rawurlencode() vs. urlencode() but I > do not think I see how it would save me any calls? Would you give me > another hint? AFAIK, rawurlencode() encodes all characters with their %xx counterparts, so that you won't have to encode spaces aka + separately. Btw, why you do you need to encode them anyway? Tue, 08 May 2007 10:27:43 -0400 http://bugs.horde.org/ticket/5337#t32779 > AFAIK, rawurlencode() encodes all characters with their %xx counterparts, so that > you won't have to encode spaces aka + separately. Btw, why you do you need to > encode them anyway? You are right; I had misread the documentation on rawurlencode(). On second thought, it is possible that the "+" to "%20" modification is not required. I think when I wrote that function I had not yet discovered the bug in HTTP_WebDAV_Server and so I was overcompensating. I will take out that line and test. Tue, 08 May 2007 10:39:44 -0400 http://bugs.horde.org/ticket/5337#t32782 Ok, I remember the reason now: When browsing using Mac's Finder as the WebDAV client, the folder is presented in the UI with '+' instead of a space. Thus, %20 is required. I have changed the function to call rawurlencode(). Tue, 08 May 2007 10:43:04 -0400 http://bugs.horde.org/ticket/5337#t32785 Committed, thanks. Tue, 26 Jun 2007 07:18:02 -0400 http://bugs.horde.org/ticket/5337#t34693