Tickets :: [#5337] Add browse API call to implement WebDAV read support

6.0.0-alpha14

6/30/25

Summary	Add browse API call to implement WebDAV read support
Queue	Gollem
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	bklang (at) horde (dot) org
Created	05/07/2007 (6629 days ago)
Due
Updated	06/26/2007 (6579 days ago)
Assigned	05/08/2007 (6628 days ago)
Resolved	06/26/2007 (6579 days ago)
Milestone
Patch	Yes

06/26/2007 11:18:02 AM	Jan Schneider	Comment #7 State ⇒ Resolved	Reply to this comment
Committed, thanks.

05/08/2007 02:48:12 PM	Jan Schneider	Assigned to Jan Schneider State ⇒ Assigned

05/08/2007 02:43:17 PM	Ben Klang	Deleted Original Message

05/08/2007 02:43:04 PM	Ben Klang	Comment #6 New Attachment: gollem-browse-v3.patch	Reply to this comment
Ok, I remember the reason now: When browsing using Mac's Finder as the WebDAV client, the folder is presented in the UI with '+' instead of a space. Thus, %20 is required. I have changed the function to call rawurlencode().

05/08/2007 02:39:44 PM	Ben Klang	Comment #5	Reply to this comment
AFAIK, rawurlencode() encodes all characters with their %xx counterparts, so that you won't have to encode spaces aka + separately. Btw, why you do you need to encode them anyway? You are right; I had misread the documentation on rawurlencode(). On second thought, it is possible that the "+" to "%20" modification is not required. I think when I wrote that function I had not yet discovered the bug in HTTP_WebDAV_Server and so I was overcompensating. I will take out that line and test.

05/08/2007 02:27:43 PM	Jan Schneider	Comment #4	Reply to this comment
I checked the documentation on rawurlencode() vs. urlencode() but I do not think I see how it would save me any calls? Would you give me another hint? AFAIK, rawurlencode() encodes all characters with their %xx counterparts, so that you won't have to encode spaces aka + separately. Btw, why you do you need to encode them anyway?

05/08/2007 02:09:37 PM	Ben Klang	Deleted Original Message

05/08/2007 02:07:43 PM	Ben Klang	Comment #3 New Attachment: gollem-browse-v2.patch	Reply to this comment
Here is an updated patch with the quotes converted from single to double for gettext. I checked the documentation on rawurlencode() vs. urlencode() but I do not think I see how it would save me any calls? Would you give me another hint?

05/08/2007 08:06:18 AM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
Please use double quotes for the gettext strings, and you can probably save one str_replace() call by using rawurlencode() instead of urlencode().

05/07/2007 11:31:13 PM	Ben Klang	Comment #1 Priority ⇒ 1. Low State ⇒ New New Attachment: gollem-browse.patch Queue ⇒ Gollem Summary ⇒ Add browse API call to implement WebDAV read support Type ⇒ Enhancement	Reply to this comment
This patch adds a function, _gollem_browse() to Gollem's API to enable browsing Gollem/VFS shares via WebDAV. Two additional supporting functions are added to the Gollem:: class. If this patch is merged I will also implement the _gollem_put() method to complete WebDAV support (and I believe close a bounty in the process). Note that there is a bug in HTTP_WebDAV_Server which affects any filename containing "+", "%" or any other filename with urlencoded characters. A bug has been filed upstream. Even without this fixed, all files and directories without special characters are handled properly.