[#5200] word icon not appearing if msword in mime_drivers.php not enabled
Summary word icon not appearing if msword in mime_drivers.php not enabled
Queue Gollem
Queue Version 1.0.2
Type Enhancement
State Rejected
Priority 1. Low
Owners
Requester pedretti (at) eco (dot) unibs (dot) it
Created 04/02/2007 (459 days ago)
Due
Updated 04/07/2007 (454 days ago)
Assigned
Resolved 04/02/2007 (459 days ago)
Attachments
Milestone
Patch No

History
04/07/2007 Chuck Hagenbuch Comment #7 Reply to this comment
It would be better to add an option to a driver configuration array
that allows a user to disable the MIME Viewer rendering yet keep the
icon definitions.
Even better (imo), we should just dissociate icons from viewers.
04/06/2007 Michael Slusarz Comment #6 Reply to this comment
Any reason not to prefill $mime_drivers['horde']['default']['icons']
with all of the MIME types we can handle so that the icons show up
out of the box and let the other drivers override the icons as needed?
Much larger mime_drivers.php files.  You will have to define every 
MIME string twice - once in the icons array and once when defining the 
driver.  For a driver like the enscript driver (with 30+ MIME types 
defined), that is a lot of superfluous definitions.

It would be better to add an option to a driver configuration array 
that allows a user to disable the MIME Viewer rendering yet keep the 
icon definitions.  However, this will have to wait for Horde 4 because 
it will break BC.

04/02/2007 Matt Selsky Comment #5 Reply to this comment
Any reason not to prefill $mime_drivers['horde']['default']['icons'] 
with all of the MIME types we can handle so that the icons show up out 
of the box and let the other drivers override the icons as needed?

04/02/2007 Michael Slusarz Comment #4 Reply to this comment
Is there a sample of this somewhere? I didn't see anything in the
wiki or the list archives.  I don't have wvWare, but I still want the
Word icon.   Similar to how the PDF Viewer works.  Is the solution to
have render() return $this->mime_part->getContents() if the binary
can't be found?
I thought this was in the FAQ, but I could be wrong.  Anyway, in 
horde/config/mime_drivers.php, just add an entry to 
$mime_drivers['horde']['default']['icons'] with the MIME types you 
want to define icons for.  i.e.
'application/vnd.ms-word' => 'msword.png'
04/02/2007 Matt Selsky Comment #3 Reply to this comment
Is there a sample of this somewhere? I didn't see anything in the wiki 
or the list archives.  I don't have wvWare, but I still want the Word 
icon.   Similar to how the PDF Viewer works.  Is the solution to have 
render() return $this->mime_part->getContents() if the binary can't be 
found?
04/02/2007 Michael Slusarz Comment #2
State ⇒ Rejected
Reply to this comment
Then alter your mime_drivers.php as appropriate.
04/02/2007 pedretti (at) eco (dot) unibs (dot) it Comment #1
Queue ⇒ Gollem
Summary ⇒ word icon not appearing if msword in mime_drivers.php not enabled
Type ⇒ Enhancement
Priority ⇒ 1. Low
State ⇒ New
Reply to this comment
I am using gollem 1.0.3.
I noted that when msword in mime_drivers.php is enabled, a nice word 
icon appear next to word file, but there is a standard text icon if 
msword is not selected; would be nice if the word ico appears even 
when msword is not enabled.