[#4818] Must check type before attempting delete
Summary Must check type before attempting delete
Queue Gollem
Queue Version HEAD
Type Bug
State Resolved
Priority 2. Medium
Owners
Requester Ben Klang <ben (at) alkaloid (dot) net>
Created 12/29/2006 (654 days ago)
Due
Updated 01/04/2007 (648 days ago)
Assigned 01/03/2007 (649 days ago)
Resolved 01/04/2007 (648 days ago)
Attachments gollem-delete-file-check.patch Download
Milestone
Patch No

History
01/04/2007 Michael Slusarz Comment #4
State ⇒ Resolved		 Reply to this comment
Committed, thanks.
01/03/2007 Ben Klang Comment #3
New Attachment: gollem-delete-file-check.patch Download		 Reply to this comment
Retrying...
01/03/2007 Michael Slusarz Deleted Attachment: gollem-delete-file-check.patch
 
01/03/2007 Michael Slusarz Comment #2
State ⇒ Feedback		 Reply to this comment
Patch is empty.
12/29/2006 Ben Klang Comment #1
Queue ⇒ Gollem
New Attachment: gollem-delete-file-check.patch Download
Priority ⇒ 2. Medium
State ⇒ Unconfirmed
Summary ⇒ Must check type before attempting delete
Type ⇒ Bug		 Reply to this comment
When requesting to delete a VFS object, Gollem first tries to delete 
the object as a file.  If that fails for any reason (database error, 
permissions, whatever), it retries the delete as a directory.  The 
attached patch checks the object type and calls the appropriate method.