[#4640] passwd_expect patch
Summary passwd_expect patch
Queue Passwd
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners
Requester asuffield (at) suffields (dot) me (dot) uk
Created 11/09/2006 (549 days ago)
Due
Updated 11/12/2006 (546 days ago)
Assigned
Resolved 11/12/2006 (546 days ago)
Attachments passwd_expect.diff Download
Milestone
Patch

History
11/12/2006 Jan Schneider Comment #2
State ⇒ Resolved		 Reply to this comment
Committed, thanks.
11/09/2006 asuffield (at) suffields (dot) me (dot) uk Comment #1
Summary ⇒ passwd_expect patch
Priority ⇒ 1. Low
Type ⇒ Bug
State ⇒ Unconfirmed
New Attachment: passwd_expect.diff Download
Queue ⇒ Passwd		 Reply to this comment
The attached patch was required for me to get passwd_expect to work
correctly.

I cannot explain why stdin might be in non-blocking mode, but it was,
and so sometimes expect would miss the username/password strings. I
can only put this one down to deep crackfulness on the part of tcl,
expect, apache, or php, and express my strong desire to never know
what is going on there. Understanding this can only lead to
pain. Forcing stdin into blocking mode ensures that it always works.

The exp_continue is necessary because otherwise, if expect sees
$fingerprint_string, it does not bother looking for $password_string
or sending the old password. Obviously nobody ever tested this, it
can't ever have worked.