Tue, 16 Mar 2010 17:47:15 -0400 http://bugs.horde.org/ticket/4221 Off-by-one error: Selecting NO for 'Save Attachments with message in sent-mail folder' and attaching PHP public key removes all but one of the attachments Steps to recreate: Compose new message Select 'Attach a copy of your PGP public key to your message?' Attach a file Select 'NO' for 'Save Attachments with message in sent-mail folder?' Send message The message that is stored in the sent folder will contain the original attachment and the PGP attachment will be stripped. Mon, 31 Jul 2006 13:04:41 -0400 http://bugs.horde.org/ticket/4221#t22477 Occurs in HEAD also. Wed, 09 Aug 2006 20:09:51 -0400 http://bugs.horde.org/ticket/4221#t22886 After further investigation - this is going to be extremely difficult to fix without either breaking BC or having to rewrite MIME_Part in IMP. Essentially the issue is that, when creating complex MIME_Parts ourselves (i.e. not from pre-existing mail data), the MIME ID's are not dynamically updated. Therefore, it is impossible to access any MIME parts except for the outer-most container parts (i.e. parts 1, 2, 3). Sun, 20 Aug 2006 02:58:56 -0400 http://bugs.horde.org/ticket/4221#t23210 > After further investigation - this is going to be extremely difficult > to fix without either breaking BC or having to rewrite MIME_Part in > IMP. Essentially the issue is that, when creating complex MIME_Parts > ourselves (i.e. not from pre-existing mail data), the MIME ID's are > not dynamically updated. Therefore, it is impossible to access any > MIME parts except for the outer-most container parts (i.e. parts 1, > 2, 3). So we end up not stripping one attachment that we should? I'm not sure I follow why the above means that, but if that's the case at least this isn't destructive. If you confirm, please stall this for 5.0. Thu, 25 Oct 2007 23:18:53 -0400 http://bugs.horde.org/ticket/4221#t38081 > So we end up not stripping one attachment that we should? I'm not > sure I follow why the above means that, but if that's the case at > least this isn't destructive. If you confirm, please stall this for > 5.0. What I mean is that if we create a multipart/mixed message ourself, and then populate with subparts, these parts have no MIME IDs - i.e. these IDs can not be dynamically assigned/determined by MIME_Part. Unless you specifically set the MIME IDs at creation time - which we do when rebuilding from IMAP message data for example - it is impossible to access the individual MIME parts. IIRC, this off-by-one issue deals with this limitation, and there is no solution except to make BC-breaking changes to MIME_Part. So stalling for Horde 5. Wed, 31 Oct 2007 23:25:12 -0400 http://bugs.horde.org/ticket/4221#t38294 Un-stalling Sat, 08 Nov 2008 22:20:49 -0500 http://bugs.horde.org/ticket/4221#t50533 Fixed in IMP 5. Mon, 08 Dec 2008 01:45:42 -0500 http://bugs.horde.org/ticket/4221#t51137 Changes have been made in Git for this ticket: Fix for Ticket #4221. Fix stripping attachments when saving to sent-mail folder when attaching the PGP public key. http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=77acfeb007d1047f940e02ed5b0d8d4800ed0e0f&r2=6a745eaa96a8f63c528d1b9361d5d320e670f0cd http://git.horde.org/diff.php/imp/lib/Compose.php?rt=horde-git&r1=2bba73985835771c1d010717c198a250aadc2547&r2=6a745eaa96a8f63c528d1b9361d5d320e670f0cd Tue, 12 Jan 2010 18:55:31 -0500 http://bugs.horde.org/ticket/4221#t57471