[#3973] Changes link sometime shows diff to self
Summary Changes link sometime shows diff to self
Queue Chora
Queue Version HEAD
Type Bug
State Resolved
Priority 2. Medium
Owners
Requester Michael Slusarz <slusarz (at) horde (dot) org>
Created 05/24/2006 (724 days ago)
Due
Updated 05/24/2006 (724 days ago)
Assigned 05/24/2006 (724 days ago)
Resolved 05/24/2006 (724 days ago)
Attachments
Milestone
Patch

History
05/24/2006 Chuck Hagenbuch Comment #4
State ⇒ Resolved
Reply to this comment
Hee hee. This was possible entirely through CSS. I'm happy with myself.

... and back to real work now.
05/24/2006 Jan Schneider Comment #3 Reply to this comment
> Do folks think that if you click the diff icon on the selected row,
> it should _always_ show diffs to the previous revision anyway? Or

Yes.
05/24/2006 Chuck Hagenbuch Comment #2
State ⇒ Feedback
Reply to this comment
This happens when you've selected the row, then click its diff icon. So not a bug, but perhaps a UI issue.

Do folks think that if you click the diff icon on the selected row, it should _always_ show diffs to the previous revision anyway? Or perhaps just not do anything?
05/24/2006 Michael Slusarz Summary ⇒ Changes link sometime shows diff to self
 
05/24/2006 Michael Slusarz Comment #1
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Queue ⇒ Chora
Summary ⇒ Change link sometime shows diff to self
Reply to this comment
Not 100% reproducible, but I have seen this on multiple occasions.
Steps to reproduce last time:
1. Browser has not visited chora yet since being opened, and hasn't visited today (just in case this is a cookie problem)
2. Directly access a file entry.  i.e. http://cvs.horde.org/framework/IMAP/IMAP/Search.php
3. Click on the changes icon for any entry.
4. The diff page tries to diff that version to itself - so obviously, there are no changes.

I noticed in step 3 that the r1 parameter of the URL was "0".  When I went back to that page the r1 parameter was correctly set to the previous revision of that branch.