Custom folder icons not shown in sidebar [patch]

As discussed in the imp mailing list, custom folder icons ar

Tue, 13 Dec 2005 02:54:13 -0500

As discussed in the imp mailing list, custom folder icons are shown in imp's folder view, but not in the menu to the left. Here are the patches for a working version, but bc is broken, because the hook's return values changed. I added a comment to UPGRADING in horde. Maybe there should be something in imp? Problem is that the patches affect horde and imp. I also added a spam folder icon for the example in hooks.php.dist to work fine and besides hope that my changes in hooks.php.dist to the kolab example are ok - I cannot test this. Regards, Ollie.

Upgrading infos added.

Tue, 13 Dec 2005 02:54:56 -0500

Upgrading infos added.

Menu folders...

Tue, 13 Dec 2005 02:56:35 -0500

Menu folders...

folders view

Tue, 13 Dec 2005 02:57:02 -0500

folders view

example hooks

Tue, 13 Dec 2005 02:57:35 -0500

example hooks

spam folder icon for the example hook

Tue, 13 Dec 2005 02:58:33 -0500

spam folder icon for the example hook

1) Please try the current CVS first, I saw that Chuck commit

Tue, 13 Dec 2005 04:39:02 -0500

1) Please try the current CVS first, I saw that Chuck committed something yesterday or two days ago. 2) The upgrading instructions should go to IMP, because IMP is breaking bc in expecting a different return value from the hook. 3) We already added a spam folder icon to HEAD that is always used now. 4) AFAICS you merged the two examples in hooks.php.dist, why? 5) Don't set unnecessary image attributes in the hooks code. Hm, now looking at the patches again, and what Chuck committed, the icons will probably work already if you replace $dir2 with $mbox_icons in tree_folders.php.

Here are my comments: 1) I don't think Chucks patch will

Tue, 13 Dec 2005 05:29:37 -0500

Here are my comments: 1) I don't think Chucks patch will work, because the first thing I did was adding the hook call to tree_folders.php and it didn't. This is because folders.php need the complete -code and tree_folders.php simply the filename. Because I don't have a HEAD installation running, can someone confirm that there is still a problem? Then I will improve my patches and upload them again. 4) I changed the hook examples because the old one won't work with the new code. 5) Those are used in folders.php. I could remove the 'alt' tag and replace it with a default description like _("Mailbox").

Please see: http://lists.horde.org/archives/cvs/Week-of-Mon

Tue, 20 Dec 2005 02:37:33 -0500

Please see: http://lists.horde.org/archives/cvs/Week-of-Mon-20051219/052302.html If someone would like to backport this to 4.1, that would be great. If not, then we should probably close this bug.

Fine by me to close it..

Tue, 20 Dec 2005 11:51:29 -0500

Fine by me to close it..

As 4.2 is long away in the future, I suggest we leave it ope

Tue, 20 Dec 2005 12:05:24 -0500

As 4.2 is long away in the future, I suggest we leave it open. If not to backport the solution to 4.1, then to find a temporary hack.

Fixed in 4.1.

Wed, 11 Jan 2006 19:39:16 -0500

Fixed in 4.1.