Fri, 04 Jul 2008 22:29:40 -0400 http://bugs.horde.org/ticket/2834 patch for qmail-ldap Hi I am sending a patch for vacation module. Highlights: * specify LDAP Protocol Version * LDAP attribute for marking active vacation message can be array - more entries - eg: 'reply', 'nolocal'. The value of the 'active' attribute is then specified as: reply|nolocal * the vacation message format is modified for qmail-ldap (for now hardcoded in 2 places) Example: "%HEADER%\nSubject: " . _("On vacation message (Autoreply to: %SUBJECT%)") . "\n\n" . _("I'm on vacation and will not be reading my mail for a while.") . "\n" . _("Your mail will be dealt with when I return.") . "\n"; * if vacation message is empty, then the default one is pre-filled Mon, 24 Oct 2005 10:16:21 -0400 http://bugs.horde.org/ticket/2834#t12834 > * LDAP attribute for marking active vacation message can be array - > more entries - eg: 'reply', 'nolocal'. The value of the 'active' > attribute is then specified as: reply|nolocal What is the unset() call for? > * the vacation message format is modified for qmail-ldap (for now > hardcoded in 2 places) > Example: > "%HEADER%\nSubject: " . _("On vacation message (Autoreply to: > %SUBJECT%)") . "\n\n" . _("I'm on vacation and will not be reading my > mail for a while.") . "\n" . _("Your mail will be dealt with when I > return.") . "\n"; This breaks any other driver, or am I missing something? Where is %HEADER% being replaced? Mon, 24 Oct 2005 12:24:24 -0400 http://bugs.horde.org/ticket/2834#t12868 hi thanks for prompt reply :-) >> * LDAP attribute for marking active vacation message can be array - >> more entries - eg: 'reply', 'nolocal'. The value of the 'active' >> attribute is then specified as: reply|nolocal > > What is the unset() call for? it's because ldap_get_attributes adds to returned array the number of attributes in the entry (see: http://www.php.net/manual/en/function.ldap-get-attributes.php). We don't want to have the value of "count" in the result (eg.: 2|reply|nolocal) > >> * the vacation message format is modified for qmail-ldap (for now >> hardcoded in 2 places) >> Example: >> "%HEADER%\nSubject: " . _("On vacation message (Autoreply to: >> %SUBJECT%)") . "\n\n" . _("I'm on vacation and will not be reading my >> mail for a while.") . "\n" . _("Your mail will be dealt with when I >> return.") . "\n"; > > This breaks any other driver, or am I missing something? Where is > %HEADER% being replaced? 1. see http://www.qmail-ldap.org/wiki/LDAP_REPLYTEXT 2. this patch will break only other LDAP using mailsystems (hardcoding is done only in Driver/ldap.php). Solution TODO: a) specify mailsystem type in the configuration (exim, qmail-ldap) b) use callback for encoding/decoding vacation message if you would like me to do it, just say a or b :-) Mon, 24 Oct 2005 14:44:00 -0400 http://bugs.horde.org/ticket/2834#t12877 to be clear: callback = hook Mon, 24 Oct 2005 14:45:36 -0400 http://bugs.horde.org/ticket/2834#t12878 >>> * LDAP attribute for marking active vacation message can be array - >>> more entries - eg: 'reply', 'nolocal'. The value of the 'active' >>> attribute is then specified as: reply|nolocal >> >> What is the unset() call for? > it's because ldap_get_attributes adds to returned array the number of > attributes in the entry (see: > http://www.php.net/manual/en/function.ldap-get-attributes.php). We > don't want to have the value of "count" in the result (eg.: > 2|reply|nolocal) Committed. >>> * the vacation message format is modified for qmail-ldap (for now >>> hardcoded in 2 places) >>> Example: >>> "%HEADER%\nSubject: " . _("On vacation message (Autoreply to: >>> %SUBJECT%)") . "\n\n" . _("I'm on vacation and will not be reading my >>> mail for a while.") . "\n" . _("Your mail will be dealt with when I >>> return.") . "\n"; >> >> This breaks any other driver, or am I missing something? Where is >> %HEADER% being replaced? > > 1. see http://www.qmail-ldap.org/wiki/LDAP_REPLYTEXT > 2. this patch will break only other LDAP using mailsystems > (hardcoding is done only in Driver/ldap.php). Solution TODO: No, it breaks *all* drivers because it changes $vacationtxt which is passed to all drivers, but only qmail LDAP understands it. > a) specify mailsystem type in the configuration (exim, qmail-ldap) > b) use callback for encoding/decoding vacation message b) as long as it still works as it did before, for standard setups. Tue, 25 Oct 2005 05:53:41 -0400 http://bugs.horde.org/ticket/2834#t12901 No feedback. Mon, 28 Nov 2005 11:05:37 -0500 http://bugs.horde.org/ticket/2834#t14246