[#2366] from_addr not always available for vacation.php
Summary from_addr not always available for vacation.php
Queue Ingo
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners
Requester sky (at) columbia (dot) edu
Created 08/01/2005 (1163 days ago)
Due
Updated 08/02/2005 (1162 days ago)
Assigned 08/02/2005 (1162 days ago)
Resolved 08/02/2005 (1162 days ago)
Attachments vacation.php.patch Download
Milestone
Patch No

History
08/02/2005 Jan Schneider State ⇒ Resolved
 
08/02/2005 sky (at) columbia (dot) edu Comment #3 Reply to this comment
This solution is really awkward, though it works. Try what I
committed instead.
it works, thanks.
08/02/2005 Jan Schneider Comment #2
State ⇒ Feedback		 Reply to this comment
This solution is really awkward, though it works. Try what I committed 
instead.
08/01/2005 sky (at) columbia (dot) edu Comment #1
Summary ⇒ from_addr not always available for vacation.php
Priority ⇒ 1. Low
Type ⇒ Bug
State ⇒ Unconfirmed
Queue ⇒ Ingo
New Attachment: vacation.php.patch Download		 Reply to this comment
$identity->getAll('from_addr') is not always set, if IMP and/or manual 
account creation isn't done.  Our instance, in particular, displays no 
address by default for the user.  This is fixed in the attached patch 
by instead calling:
$identity->getDefaultFromAddress()
which has the disadvantage of only getting one address, but 
getDefaultFromAddress will fall over to the Auth::getAuth() string if 
from_addr is not available.
...and the comments in the vacation.php file suggest that the goal is 
to get "at least one address," so this seems to be better.

Alternatively, it could try  getAll('from_addr'), and if that returns 
nothing, then call getDefaultFromAddress().   That patch would look 
like:
57a58
59c60,66 <     $vacation->setVacationAddresses(implode("\n", 
$identity->getAll('from_addr')));
---

     if (count($identity->getAll('from_addr')) > 0) {
         $vacation->setVacationAddresses(implode("\n", 
$identity->getAll('from_addr')));
     }
     else {
         require_once 'Horde/MIME.php';
         
$vacation->setVacationAddresses(MIME::bareAddress($identity->getDefaultFromAddress()));
     }