[#197] have annotate mode link to line's prior version
Summary have annotate mode link to line's prior version
Queue Chora
Queue Version HEAD
Type Enhancement
State Resolved
Priority 1. Low
Owners Chuck Hagenbuch <chuck (at) horde (dot) org>
Requester danielc (at) analysisandsolutions (dot) com
Created 05/19/2004 (1459 days ago)
Due
Updated 02/02/2007 (470 days ago)
Assigned 12/07/2004 (1257 days ago)
Resolved 02/02/2007 (470 days ago)
Attachments
Milestone
Patch

History
02/02/2007 Chuck Hagenbuch Assigned to Chuck Hagenbuch
 
02/02/2007 Chuck Hagenbuch Comment #7
State ⇒ Resolved
Reply to this comment
Implemented in HEAD.
02/02/2007 Chuck Hagenbuch Deleted Attachment: get_diff_chunks.pike
 
01/02/2006 oyasumi+chora (at) gmail (dot) com Comment #6
New Attachment: get_diff_chunks.pike
Reply to this comment
I have implemented this feature in another CVS visualizer written in Pike: Code Librarian. Here is the algorithm for reading diffs produced by cvs rdiff, picking out from-line in revision r1 and to-line in revision r2 for every diff chunk between the two revisions. It is used for generating the line number links in, for instance, http://pike.ida.liu.se/development/cvs/diff-popup.xml?module=Pike&file=7.7/src/post_modules/GTK2/source/gtkcomboboxentry.pre&from=1.1&to=1.2

The output produced is a mapping with an array of chunk mappings listing their from/to line numbers and number of diff lines in either revision, and an array of diff lines, one for each line in the produced unidiff. Each diff line mapping also lists the corresponding lines in the from/to revisions.
02/18/2005 Jan Schneider Comment #5 Reply to this comment
02/18/2005 Jan Schneider Taken from Horde DevelopersHorde Developers
 
02/18/2005 Jan Schneider Comment #4
State ⇒ Accepted
Reply to this comment
Set correct version.
12/07/2004 Chuck Hagenbuch Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
 
05/20/2004 Jan Schneider Comment #3
State ⇒ Accepted
Reply to this comment
That sounds like a nice feature. Actually something that I'm working around very often at the moment by having several views of the same file open at the same time.
Does anyone have an idea how this could be implemented cleanly UI-wise?

Btw. cvs.php.net currently runs CVS HEAD code from a few weeks ago.
05/19/2004 danielc (at) analysisandsolutions (dot) com Comment #2 Reply to this comment
In editing, I forgot to mention, my experience with Chora comes from viewing cvs.php.net.  I don't know which version of Chora is being run there, but I'm sure Chuck does.
05/19/2004 danielc (at) analysisandsolutions (dot) com Comment #1
State ⇒ New
Priority ⇒ 1. Low
Type ⇒ Enhancement
Queue ⇒ Chora
Reply to this comment
When looking at a file in annotate mode, it indicates the version each line was modified in.  That version number (let's say x) is hyperlinked to the view mode of that version.  But, what I'm usually looking for is what was on the given line _before_ it was changed.  So, it would be very helpful to have a link to that line in version x-1 of the file, with the display of x-1 being in annotate mode too, so I can jump back another revision again if necessary.