6.0.0-beta1
8/23/25

[#13350] Completed task not detected as notification
Summary Completed task not detected as notification
Queue Nag
Queue Version FRAMEWORK_5_2
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester almarin (at) um (dot) es
Created 07/11/2014 (4061 days ago)
Due
Updated 07/12/2014 (4060 days ago)
Assigned
Resolved 07/12/2014 (4060 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
07/12/2014 05:23:40 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit d87efc3599f0b7e2d45429a80828b4f6a356d6b9
Author: Alfonso Marín Marín <almarin@um.es>
Date:   Sat Jul 12 13:18:06 2014 -0400

     Bug: 13350  Fix detecting task completion when sending task 
change notifications.

     Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>

  nag/lib/Driver.php |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/d87efc3599f0b7e2d45429a80828b4f6a356d6b9
07/12/2014 05:20:08 PM Michael Rubinsky Comment #3
Assigned to Michael Rubinsky
State ⇒ Resolved
Reply to this comment
Thanks!
07/12/2014 05:19:50 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 6a0acbc2bd64f4bc4829f539415caecb8f7eb9e7
Author: Alfonso Marín Marín <almarin@um.es>
Date:   Sat Jul 12 13:18:06 2014 -0400

     Bug: 13350  Fix detecting task completion when sending task 
change notifications.

     Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>

  nag/lib/Driver.php |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/6a0acbc2bd64f4bc4829f539415caecb8f7eb9e7
07/11/2014 09:10:09 AM almarin (at) um (dot) es Comment #1
Priority ⇒ 1. Low
New Attachment: Driver.php.patch Download
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Nag
Summary ⇒ Completed task not detected as notification
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
In task change notifications, completion change is not detected, 
because in Driver.php the original task is toggled before retrieving 
the copy to compare.

I attach a very kick and dirty path to illustrate the problem.

Saved Queries