[#1264] Sorting files by date in Chora
Summary Sorting files by date in Chora
Queue Horde Framework Packages
Type Bug
State Resolved
Priority 2. Medium
Owners Chuck Hagenbuch <chuck (at) horde (dot) org>
Requester olli (dot) korhonen (at) fimx (dot) fi
Created 01/28/2005 (1439 days ago)
Due
Updated 01/28/2005 (1439 days ago)
Assigned 01/28/2005 (1439 days ago)
Resolved 01/28/2005 (1439 days ago)
Attachments
Milestone
Patch No

History
01/28/2005 Chuck Hagenbuch Comment #2
State ⇒ Resolved		 Reply to this comment
Thanks for the catch - fixed now.
01/28/2005 Chuck Hagenbuch Assigned to Chuck Hagenbuch
State ⇒ Assigned
 
01/28/2005 olli (dot) korhonen (at) fimx (dot) fi Comment #1
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Sorting files by date in Chora
Queue ⇒ Horde Framework Packages		 Reply to this comment
File sorting in Chora is always ascending because of this little typo 
in framework/VC/VC/cvs.php. Patch included.

--- horde-3.0.2/lib/Horde/VC/cvs.php    2005-01-07 02:23:51.000000000 +0200
+++ horde-3.0.2_patch/lib/Horde/VC/cvs.php      2005-01-28 
16:51:18.042600057 +0200
@@ -510,7 +510,7 @@
          $bb = $b->queryLastLog();
          if ($aa->queryDate() == $bb->queryDate()) {
              return 0;
-        } elseif ($this->sortDir = VC_SORT_ASCENDING) {
+        } elseif ($this->sortDir == VC_SORT_ASCENDING) {
              return ($aa->queryDate() < $bb->queryDate()) ? 1 : -1;
          } else {
              return ($bb->queryDate() < $aa->queryDate()) ? 1 : -1;