Summary | Icalendar.php vCard import case sensitive |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | carlos.velasco (at) nimastelecom (dot) com |
Created | 07/25/2013 (4314 days ago) |
Due | |
Updated | 03/09/2015 (3722 days ago) |
Assigned | 03/09/2015 (3722 days ago) |
Resolved | 03/09/2015 (3722 days ago) |
Milestone | |
Patch | Yes |
years and years and years.
ok through web.
Could be fixed in the past? It has been more than 1 year since this report.
I should try through CardDAV, right now I don't know if the problem
was present through web or CardDAV.
State ⇒ Feedback
all. The example vCard file imports fine for me. We UPPER the needed
values in Turba, so I'm not sure what the problem is here.
commit b790c81665df68ae5490702deec15a9ee08f726f
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Mar 9 12:49:27 2015 -0400
Revert "
Bug: 12501Parameter names and values are case insensitive."This broke unit tests.
This reverts commit c9112bc51b29ea3f804cb647db1ebd826853b0bd.
framework/Icalendar/lib/Horde/Icalendar.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/b790c81665df68ae5490702deec15a9ee08f726f
State ⇒ Resolved
Taken from Jan Schneider
commit c9112bc51b29ea3f804cb647db1ebd826853b0bd
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Mar 9 11:59:12 2015 -0400
Bug: 12501Parameter names and values are case insensitive.framework/Icalendar/lib/Horde/Icalendar.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/c9112bc51b29ea3f804cb647db1ebd826853b0bd
"specification":http://www.imc.org/pdi/vcard-21.rtf I did some
researches once again.
It is described in Section 2, that property names and property
parameters can be defined as case insensitive:
<pre>
A property is the definition of an individual attribute describing the vCard.
A property takes the following form:
PropertyName [?;? PropertyParameters] ?:? PropertyValue
as shown in the following example:
TEL;HOME:+1-919-555-1234
A property takes the form of one or more lines of text. The specification of
property names and property parameters is case insensitive.
The property name can be one of a set of pre-defined strings.
</pre>
This fact is consistent with
"RFC2426":http://www.ietf.org/rfc/rfc2426.txt (page 29 and 31). So a
"vCard reader module" is meant to support both spellings.
as described in
ticket #12561the problem still exists. Defined fields(phone numbers) between Thunderbird and Horde are not synchronizing
correctly.
Michael Rubinsky labeled my entry as a duplicate, as there is
obviously a common problem (
ticket #12501), which has got to be solved.Michaels last input concerning this topic dated back at the end of
July 2013 so that I want to ask, if there are any new realizings and
if the problem is going to be solved soon.
Do you need any help from our side for support?
Thanks for your short update.
Best regards,
Uwe
Taken from Michael Rubinsky
Assigned to Jan Schneider
unconditionally - there may be other parameters that *are* case
sensitive or that should otherwise have the case preserved.
Assigning to Jan to look at.
Assigned to Michael Rubinsky
State ⇒ Assigned
parameter names.
it is talking about.
Priority ⇒ 1. Low
State ⇒ Not A Bug
This is due to case sensitive.
RFC2426 states these should not be case sensitive:
parameter names.
New Attachment: vcard-2.patch
New Attachment: vcard.patch
Priority ⇒ 3. High
State ⇒ Unconfirmed
Patch ⇒ Yes
Milestone ⇒
Summary ⇒ Icalendar.php vCard import case sensitive
Type ⇒ Bug
Queue ⇒ Horde Framework Packages
===
BEGIN:VCARD
VERSION:3.0
N:;KKKK2
FN:KKKK2
TEL;TYPE=WORK:1111
TEL;TYPE=home:2222
X-MOZILLA-HTML:FALSE
END:VCARD
===
The "WORK" telephone is imported ok. But the "home" one is not imported.
This is due to case sensitive.
RFC2426 states these should not be case sensitive:
===
tel-type = "HOME" / "WORK" / "PREF" / "VOICE" / "FAX" / "MSG"
/ "CELL" / "PAGER" / "BBS" / "MODEM" / "CAR" / "ISDN"
/ "VIDEO" / "PCS" / iana-token / x-name
; Values are case insensitive
===
Attached is a patch to Icalendar,php to "upper" all param values to
fix the problem. Although I don't know if this is the right place to
fix this, it works.
Note: I really found this problem when debugging Sogo connector sync
problems with Cardav in turba, but problem arise also when using
manual import of vcard files.