| Summary | ActiveSync: Fix warning on empty categories |
| Queue | Turba |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | mrubinsk (at) horde (dot) org |
| Requester | thomas.jarosch (at) intra2net (dot) com |
| Created | 4/17/13 (4816 days ago) |
| Due | |
| Updated | 4/17/13 (4816 days ago) |
| Assigned | |
| Resolved | 4/17/13 (4816 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
commit d48b8d04356a793dbfe544b42f3c5c851c8d2e4f
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Wed Apr 17 12:38:57 2013 -0400
Work around broken HTC clients (again) that send empty tags for
array values.
Bug: 12187Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>
turba/lib/Driver.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/d48b8d04356a793dbfe544b42f3c5c851c8d2e4f
Version ⇒ Git master
Queue ⇒ Turba
State ⇒ Resolved
commit 921eab4268f2296df1717046603df7f3d457ad81
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Wed Apr 17 12:38:57 2013 -0400
Work around broken HTC clients (again) that send empty tags for
array values.
Bug: 12187Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>
turba/lib/Driver.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/921eab4268f2296df1717046603df7f3d457ad81
I can't set the "Patch: Yes" flag for this ticket, in fact I can't modify it.
The "Synchronization" queue also has a "FRAMEWORK_3 (The current 3.x
CVS code") version category.
I can't set the "Patch: Yes" flag for this ticket, in fact I can't modify it.
The "Synchronization" queue also has a "FRAMEWORK_3 (The current 3.x
CVS code") version category.
New Attachment: 0001-ActiveSync-Fix-warning-on-empty-categories-bug-12187.patch
Milestone ⇒
State ⇒ Unconfirmed
Patch ⇒ No
Queue ⇒ Synchronization
Summary ⇒ ActiveSync: Fix warning on empty categories
Type ⇒ Bug
Priority ⇒ 1. Low
I've created an almost empty contact on a HTC Desire HD.
This results in the following PHP warning:
2013-04-17T10:21:00+02:00 WARN: HORDE [turba] PHP ERROR: implode() [<a
href='function.implode'>function.implode</a>]: Invalid arguments
passed [pid 2249 on line 2615 of
"/datastore/DEVEL/horde/turba/lib/Driver.php"]
The XML data looks like this:
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <Add>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <ClientEntryId>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I 250
2013-04-17T10:27:44+02:00 DEBUG: [17529] I </ClientEntryId>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <POOMCONTACTS:FileAs>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I Newcontact
2013-04-17T10:27:44+02:00 DEBUG: [17529] I </POOMCONTACTS:FileAs>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <POOMCONTACTS:FirstName>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I Newcontact
2013-04-17T10:27:44+02:00 DEBUG: [17529] I </POOMCONTACTS:FirstName>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <AirSyncBase:Body>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <AirSyncBase:Type>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I 1
2013-04-17T10:27:44+02:00 DEBUG: [17529] I </AirSyncBase:Type>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I
<AirSyncBase:EstimatedDataSize>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I 0
2013-04-17T10:27:44+02:00 DEBUG: [17529] I
</AirSyncBase:EstimatedDataSize>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <AirSyncBase:Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I
2013-04-17T10:27:44+02:00 DEBUG: [17529] I </AirSyncBase:Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I </AirSyncBase:Body>
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <POOMCONTACTS:Categories />
2013-04-17T10:27:44+02:00 DEBUG: [17529] I <POOMCONTACTS:Picture />
2013-04-17T10:27:44+02:00 DEBUG: [17529] I </Data>
2013-04-17T10:27:44+02:00 DEBUG: [17529]
Horde_Core_ActiveSync_Driver::changeMessage(@Contacts@, ...)
2013-04-17T10:27:45+02:00 DEBUG: [17529]
Horde_Core_ActiveSync_Driver::_smartStatMessage(@Contacts@,
516e5d01-bbf0-47d3-a116-4479ac10017b)
2013-04-17T10:27:45+02:00 DEBUG: [17529] Updating state during change
2013-04-17T10:27:45+02:00 DEBUG: [17529] I </Add>
I'll attach a fix shortly, I need to allocate the bug number first :)
Thomas