| Summary | Horde_Share: test fails |
| Queue | Horde Framework Packages |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | jan (at) horde (dot) org |
| Requester | remi (at) famillecollet (dot) com |
| Created | 01/16/2013 (4556 days ago) |
| Due | |
| Updated | 01/16/2013 (4556 days ago) |
| Assigned | |
| Resolved | 01/16/2013 (4556 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
State ⇒ Resolved
commit 577d3475ecc1d574a150cb8d59b626c37afea47d
Author: Remi Collet <fedora@famillecollet.com>
Date: Wed Jan 16 08:50:19 2013 +0100
Fix Horde_Share: test fails (
Bug #11966)Rename Horde_Share_Test_Base::callback() to callbackSetShareOb()
Avoid name conflict with PHPUnit_Framework_Assert::callback()
Signed-off-by: Jan Schneider <jan@horde.org>
framework/Share/test/Horde/Share/Base.php | 2 +-
.../Share/test/Horde/Share/Kolab/MockTest.php | 4 ++--
framework/Share/test/Horde/Share/Sql/Base.php | 2 +-
framework/Share/test/Horde/Share/Sqlng/Base.php | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/577d3475ecc1d574a150cb8d59b626c37afea47d
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ Horde_Share: test fails
Type ⇒ Bug
State ⇒ Unconfirmed
$ phpunit .
Fatal error: Cannot make static method
PHPUnit_Framework_Assert::callback() non static in class
Horde_Share_Test_Base in
/work/GIT/horde/framework/Share/test/Horde/Share/Base.php on line 12
I think this is a method name collision
A simple fix consist to rename this method
Will submit a pull request.