Tickets :: [#11783] Upgrade tasks are run for hook results

6.0.0-beta1

7/5/25

Summary	Upgrade tasks are run for hook results
Queue	IMP
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	11/29/2012 (4601 days ago)
Due
Updated	11/30/2012 (4600 days ago)
Assigned	11/30/2012 (4600 days ago)
Resolved	11/30/2012 (4600 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

11/30/2012 08:50:44 PM	Michael Slusarz	Assigned to Michael Slusarz State ⇒ Resolved

11/30/2012 08:49:57 PM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (master): commit 8e6cc32b43d7e00725dbb3e2074f7f38e41fa31a Author: Michael M Slusarz <slusarz@horde.org> Date: Fri Nov 30 13:02:03 2012 -0700 ~~Bug #11783~~: Don't re-convert mailboxes already converted to UTF-8 imp/lib/LoginTasks/SystemTask/Upgrade.php \| 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) http://git.horde.org/horde-git/-/commit/8e6cc32b43d7e00725dbb3e2074f7f38e41fa31a

11/30/2012 08:37:40 AM	Jan Schneider	Comment #3	Reply to this comment
No, the folder name hooks. If the hook provides folder names as UTF-8 like they would when hardcoded in prefs.php, the conversion from utf7-imap to utf-8 breaks them.

11/30/2012 05:36:53 AM	Michael Slusarz	Comment #2 State ⇒ Feedback Taken from Michael Slusarz	Reply to this comment
This mangles any hook results of course. No it doesn't. Upgrade tasks should be designed to be able to run multiple times. Are you talking about addressbook prefs? Maybe those need to be fixed. But every other IMP pref looks good to me.

11/29/2012 12:06:15 PM	Jan Schneider	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Upgrade tasks are run for hook results Queue ⇒ IMP Assigned to Michael Slusarz Milestone ⇒ Patch ⇒ No State ⇒ Assigned	Reply to this comment
The preference upgrade tasks are run if there is no value stored in the preference backend, but a preference hook is set. This happens because isDefault() returns false if a preference hook has been run. This mangles any hook results of course.