6.0.0-beta1
7/3/25

[#11667] Horde_Secret : broken test
Summary Horde_Secret : broken test
Queue Horde Framework Packages
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester remi (at) famillecollet (dot) com
Created 11/07/2012 (4621 days ago)
Due
Updated 11/07/2012 (4621 days ago)
Assigned
Resolved 11/07/2012 (4621 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
11/07/2012 06:55:26 PM Michael Slusarz Comment #5 Reply to this comment
I don't see these notices.
That's because he is running the unreleased beta version of 
Horde_Blowfish.  Which we do not support.
11/07/2012 04:28:38 PM Jan Schneider Comment #4 Reply to this comment
I don't see these notices.
11/07/2012 04:12:25 PM remi (at) famillecollet (dot) com Comment #3 Reply to this comment
And about the error_reporting (PHP 5.4.x) ?
11/07/2012 03:58:04 PM Jan Schneider State ⇒ Resolved
Assigned to Jan Schneider
 
11/07/2012 03:57:33 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 4b826858be184391c4468be88afa7f7582b413f7
Author: Jan Schneider <jan@horde.org>
Date:   Wed Nov 7 16:53:58 2012 +0100

     Fix long key test (Bug #11667).

  .../Secret/test/Horde/Secret/Unit/SecretTest.php   |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)

http://git.horde.org/horde-git/-/commit/4b826858be184391c4468be88afa7f7582b413f7
11/07/2012 03:40:08 PM remi (at) famillecollet (dot) com Comment #1
Priority ⇒ 1. Low
New Attachment: Horde_Secret-test.patch Download
Patch ⇒ Yes
Milestone ⇒
Summary ⇒ Horde_Secret : broken test
Type ⇒ Bug
State ⇒ Unconfirmed
Queue ⇒ Horde Framework Packages
Reply to this comment
Runnin the unit tests with PHP 5.4 raised a lots of message.
Non-static method PEAR::raiseError() should not be called statically, ...

There was 1 failure:
1) Horde_Secret_Unit_SecretTest::testLongKeyException
Failed asserting that exception of type "Horde_Secret_Exception" is thrown.

According to Bug #11566, key > 56 is no more an isue
Fixed in 
http://git.horde.org/commit.php/?rt=horde-git&commit=def22bd5e48fd39d1aa26c02af526fe5794d3890

So the testLongKeyException doesn't thrown any exception.


Attached path fixes both.

Saved Queries