Tickets :: [#11667] Horde_Secret : broken test

6.0.0-RC7

6/19/26

History
Attachments
Comment
Watch
Download

Summary	Horde_Secret : broken test
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	remi (at) famillecollet (dot) com
Created	11/7/12 (4972 days ago)
Due
Updated	11/7/12 (4972 days ago)
Assigned
Resolved	11/7/12 (4972 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

266	Michael Slusarz	Comment #5	Reply to this comment
I don't see these notices. That's because he is running the unreleased beta version of Horde_Blowfish. Which we do not support.

384	Jan Schneider	Comment #4	Reply to this comment
I don't see these notices.

254	remi (at) famillecollet (dot) com	Comment #3	Reply to this comment
And about the error_reporting (PHP 5.4.x) ?

43	Jan Schneider	State ⇒ Resolved Assigned to Jan Schneider

333	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (master): commit 4b826858be184391c4468be88afa7f7582b413f7 Author: Jan Schneider <jan@horde.org> Date: Wed Nov 7 16:53:58 2012 +0100 Fix long key test (~~Bug #11667~~). .../Secret/test/Horde/Secret/Unit/SecretTest.php \| 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) http://git.horde.org/horde-git/-/commit/4b826858be184391c4468be88afa7f7582b413f7

83	remi (at) famillecollet (dot) com	Comment #1 Priority ⇒ 1. Low New Attachment: Horde_Secret-test.patch Patch ⇒ Yes Milestone ⇒ Summary ⇒ Horde_Secret : broken test Type ⇒ Bug State ⇒ Unconfirmed Queue ⇒ Horde Framework Packages	Reply to this comment
Runnin the unit tests with PHP 5.4 raised a lots of message. Non-static method PEAR::raiseError() should not be called statically, ... There was 1 failure: 1) Horde_Secret_Unit_SecretTest::testLongKeyException Failed asserting that exception of type "Horde_Secret_Exception" is thrown. According to ~~Bug #11566~~, key > 56 is no more an isue Fixed in http://git.horde.org/commit.php/?rt=horde-git&commit=def22bd5e48fd39d1aa26c02af526fe5794d3890 So the testLongKeyException doesn't thrown any exception. Attached path fixes both.