6.0.0-alpha12
6/7/25

[#11657] Move stock ID field
Summary Move stock ID field
Queue Sesha
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners ralf.lang (at) ralf-lang (dot) de
Requester jan (at) horde (dot) org
Created 11/06/2012 (4596 days ago)
Due
Updated 12/29/2012 (4543 days ago)
Assigned 12/28/2012 (4544 days ago)
Resolved 12/29/2012 (4543 days ago)
Github Issue Link
Github Pull Request
Milestone 1
Patch No

History
12/29/2012 08:52:28 AM Ralf Lang State ⇒ Resolved
 
12/29/2012 08:51:21 AM Git Commit Comment #8 Reply to this comment
Changes have been made in Git (master):

commit 5ecc4a782929497e29bc1054339259b817c5e420
Author: Ralf Lang <lang@b1-systems.de>
Date:   Sat Dec 29 10:50:11 2012 +0200

     Load prototype earlier to make the search field display properly  #11657.

  sesha/list.php |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/5ecc4a782929497e29bc1054339259b817c5e420
12/28/2012 06:03:41 PM Jan Schneider Comment #7
State ⇒ Assigned
Reply to this comment
prototype.js is loaded too late on that page.
12/11/2012 09:16:40 PM Ralf Lang Comment #6
State ⇒ Feedback
Reply to this comment
Searching by name OR id is implemented for the moved topbar search.
I still have an UI issue: In all most views I see a "Stock Id" prompt 
in the search field but in list view, it's blank.

I have not found the root cause, probably some css. The HTML includes 
the title="Stock Id" option.
12/11/2012 09:12:08 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (master):

commit 8cd7e224f306d53be62d428f8ad45e5dbeef2bbf
Author: Ralf Lang <lang@b1-systems.de>
Date:   Tue Dec 11 23:07:06 2012 +0200

     Move quicksearch to topbar and remove the "menu" template. Allow 
search by Name or Id (Request #11657).

  sesha/admin.php          |    7 ++++++-
  sesha/docs/CHANGES       |    1 +
  sesha/list.php           |    1 -
  sesha/package.xml        |   12 +++++-------
  sesha/search.php         |    7 ++++++-
  sesha/stock.php          |    8 ++++++--
  sesha/templates/menu.inc |    9 ---------
  7 files changed, 24 insertions(+), 21 deletions(-)

http://git.horde.org/horde-git/-/commit/8cd7e224f306d53be62d428f8ad45e5dbeef2bbf
12/11/2012 09:12:04 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit 54384a6632d34ac7cf915e3da9a339127bde27ae
Author: Ralf Lang <lang@b1-systems.de>
Date:   Tue Dec 11 22:56:44 2012 +0200

     Move the search to topbar in list view and allow quicksearching 
by name and ID (Request #11657).

  sesha/list.php |   22 +++++++++++++++++++---
  1 files changed, 19 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/54384a6632d34ac7cf915e3da9a339127bde27ae
11/28/2012 10:28:24 PM Jan Schneider Comment #3 Reply to this comment
The stock ID field should by moved and the topbar search field used
instead. Bonus points for allowing both, direct ID access and search
for item name, from the search field.
What is the topbar search field? Which application uses it?
I have compared with wicked and whups which sport a similar search 
field and they have it in the same place?
Because those haven't been updated for Horde 5 yet either. See 
Kronolith, IMP, Gollem, Trean.
11/28/2012 07:40:10 PM Ralf Lang Comment #2 Reply to this comment
The stock ID field should by moved and the topbar search field used 
instead. Bonus points for allowing both, direct ID access and search 
for item name, from the search field.
What is the topbar search field? Which application uses it?
I have compared with wicked and whups which sport a similar search 
field and they have it in the same place?
11/06/2012 08:42:01 PM Jan Schneider Comment #1
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒ 1
Assigned to Ralf Lang
Queue ⇒ Sesha
Summary ⇒ Move stock ID field
Type ⇒ Bug
Priority ⇒ 1. Low
Reply to this comment
The stock ID field should by moved and the topbar search field used 
instead. Bonus points for allowing both, direct ID access and search 
for item name, from the search field.

Saved Queries