Tickets :: [#11137] Improper code in Horde/Imap/Client/Socket.php

6.0.0-beta1

7/18/25

Summary	Improper code in Horde/Imap/Client/Socket.php
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	peter (at) dobranszky (dot) com
Created	04/10/2012 (4847 days ago)
Due
Updated	08/29/2012 (4706 days ago)
Assigned
Resolved	04/10/2012 (4847 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

08/29/2012 12:36:11 PM	Git Commit	Comment #8	Reply to this comment
Changes have been made in Git (master): commit d3fd9669ad3e2e52ba88c82cebf67338b9247899 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 9 22:20:05 2012 -0600 Revert "~~Bug #11137~~: Still need to support PHP 5.2 in version 1.x of Imap_Client" This reverts commit cdc4852e8e68bc02a52dfb7c3b4f07d77a9fda8c. .../Imap_Client/lib/Horde/Imap/Client/Socket.php \| 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/d3fd9669ad3e2e52ba88c82cebf67338b9247899

04/11/2012 01:15:37 PM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (master): commit ec5863479c9b1b899e1f8181f061e8421f2f276c Author: Jan Schneider <jan@horde.org> Date: Wed Apr 11 15:08:55 2012 +0200 [mms] Fixed PHP 5.2 incompatibility (~~Bug #11137~~). framework/Imap_Client/package.xml \| 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/ec5863479c9b1b899e1f8181f061e8421f2f276c

04/11/2012 01:15:28 PM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git (develop): commit ec5863479c9b1b899e1f8181f061e8421f2f276c Author: Jan Schneider <jan@horde.org> Date: Wed Apr 11 15:08:55 2012 +0200 [mms] Fixed PHP 5.2 incompatibility (~~Bug #11137~~). framework/Imap_Client/package.xml \| 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/ec5863479c9b1b899e1f8181f061e8421f2f276c

04/10/2012 04:20:34 AM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (develop): commit d3fd9669ad3e2e52ba88c82cebf67338b9247899 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 9 22:20:05 2012 -0600 Revert "~~Bug #11137~~: Still need to support PHP 5.2 in version 1.x of Imap_Client" This reverts commit cdc4852e8e68bc02a52dfb7c3b4f07d77a9fda8c. .../Imap_Client/lib/Horde/Imap/Client/Socket.php \| 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/d3fd9669ad3e2e52ba88c82cebf67338b9247899

04/10/2012 04:20:27 AM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (develop): commit cdc4852e8e68bc02a52dfb7c3b4f07d77a9fda8c Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 9 22:18:22 2012 -0600 ~~Bug #11137~~: Still need to support PHP 5.2 in version 1.x of Imap_Client .../Imap_Client/lib/Horde/Imap/Client/Socket.php \| 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/cdc4852e8e68bc02a52dfb7c3b4f07d77a9fda8c

04/10/2012 04:19:15 AM	Michael Slusarz	Comment #3 State ⇒ Resolved Assigned to Michael Slusarz	Reply to this comment
No, that's correct, at least as of PHP 5.3: http://www.php.net/manual/en/language.oop5.constants.php It looks like that code was backported from Imap_Client 2.x, which requires 5.3, to Imap_client 1.x, which only requires 5.2.

04/10/2012 04:18:39 AM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (master): commit cdc4852e8e68bc02a52dfb7c3b4f07d77a9fda8c Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Apr 9 22:18:22 2012 -0600 ~~Bug #11137~~: Still need to support PHP 5.2 in version 1.x of Imap_Client .../Imap_Client/lib/Horde/Imap/Client/Socket.php \| 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/cdc4852e8e68bc02a52dfb7c3b4f07d77a9fda8c

04/10/2012 03:26:45 AM	peter (at) dobranszky (dot) com	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Improper code in Horde/Imap/Client/Socket.php Queue ⇒ Horde Framework Packages Milestone ⇒ Patch ⇒ No State ⇒ Unconfirmed	Reply to this comment
In lines 1436-1437 of Horde/Imap/Client/Socket.php case $e::CATENATE_BADURL: case $e::CATENATE_TOOBIG: shall be case Horde_Imap_Client_Exception::CATENATE_BADURL: case Horde_Imap_Client_Exception::CATENATE_TOOBIG: