Tickets :: [#10409] Coding and standards fixes

6.0.0-beta1

11/7/25

Summary	Coding and standards fixes
Queue	Passwd
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	vilius (at) lnk (dot) lt
Created	08/03/2011 (5210 days ago)
Due
Updated	08/04/2011 (5209 days ago)
Assigned	08/04/2011 (5209 days ago)
Resolved	08/04/2011 (5209 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

08/04/2011 09:13:34 AM	Jan Schneider	Comment #5 Assigned to Jan Schneider State ⇒ Resolved	Reply to this comment
Looks like copy'n'pasting was the problem, probably due to the whitespace changes.

08/04/2011 09:13:23 AM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git for this ticket: Correctly check for uninitialized variables, follow Horde coding standards. ~~Bug: #10409~~ Signed-off-by: Jan Schneider <jan@horde.org> 2 files changed, 21 insertions(+), 24 deletions(-) http://git.horde.org/horde-git/-/commit/65f862720f811383449d67eaec85e60fd18e4e99

08/04/2011 09:02:34 AM	vilius (at) lnk (dot) lt	Comment #3 New Attachment: 0001-Correctly-check-for-uninitialized-variables-follow-H[1].patch	Reply to this comment
Strange. Try this one made against latest HEAD. It looks the same though.

08/04/2011 08:40:23 AM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
error: patch failed: passwd/lib/Factory/Driver.php:60

08/03/2011 11:41:31 AM	vilius (at) lnk (dot) lt	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Coding and standards fixes Queue ⇒ Passwd Milestone ⇒ Patch ⇒ Yes New Attachment: 0001-Correctly-check-for-uninitialized-variables-follow-H.patch State ⇒ Unconfirmed	Reply to this comment
Patch fixes coding standards and various uninitialized variable issues.