Tickets :: [#10366] Agora fixes and refactoring for H4

6.0.0-alpha12

6/8/25

Summary	Agora fixes and refactoring for H4
Queue	Agora
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	vilius (at) lnk (dot) lt
Created	07/21/2011 (5071 days ago)
Due
Updated	08/04/2011 (5057 days ago)
Assigned	07/24/2011 (5068 days ago)
Resolved	08/04/2011 (5057 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

08/04/2011 08:41:10 AM	Jan Schneider	Comment #8 Assigned to Jan Schneider State ⇒ Resolved	Reply to this comment
Thanks.

08/04/2011 08:04:52 AM	vilius (at) lnk (dot) lt	Comment #7 New Attachment: agoraH4.tar.gz	Reply to this comment
Here you go. A modified patch with migration scripts in two steps. Hopefully I have mastered git rebase/amend/continue right. As for Agora, yes, it's ugly in some ways, but does intranet messaging just right :)

07/30/2011 12:02:23 PM	Jan Schneider	Comment #6	Reply to this comment
By the way, I have noticed that some upgrade .sql scripts were not moved from CVS to git. Was it intentional? No idea. Honestly, I've given up on Agora long ago. :)

07/30/2011 12:01:48 PM	Jan Schneider	Comment #5	Reply to this comment
Well, the scripts were separate in old version. So I just kept the same structure. Also, maybe someone would have CVS version in between year 2007 and year 2008 of Agora installed. So it would be a lot easier for them to upgrade. Or do you mean that all sql/upgrade scripts for unreleased applications when moved to H4 can be combined into one migration script? If yes, how step 5 is different from 1-4? You can safely assume that anyone migration from CVS has all SQL scripts that exist in CVS applied already. Anything else would be overcomplicating things.

07/24/2011 04:59:20 PM	vilius (at) lnk (dot) lt	Comment #4	Reply to this comment
By the way, I have noticed that some upgrade .sql scripts were not moved from CVS to git. Was it intentional?

07/24/2011 04:57:48 PM	vilius (at) lnk (dot) lt	Comment #3	Reply to this comment
Well, the scripts were separate in old version. So I just kept the same structure. Also, maybe someone would have CVS version in between year 2007 and year 2008 of Agora installed. So it would be a lot easier for them to upgrade. Or do you mean that all sql/upgrade scripts for unreleased applications when moved to H4 can be combined into one migration script? If yes, how step 5 is different from 1-4?

07/24/2011 04:42:14 PM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
Why are the migration steps 2-4 separate from 1? And there is a column name typo in the down migration in step 2.

07/21/2011 08:04:38 PM	vilius (at) lnk (dot) lt	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Agora fixes and refactoring for H4 Queue ⇒ Agora Milestone ⇒ Patch ⇒ Yes New Attachment: agora.tar.gz State ⇒ Unconfirmed	Reply to this comment
First batch of Agora fixes and refactoring for H4. Main changes: * Added driver factory and converted Agora to use it. * Added database migration scripts. * Switched Agora from MDB2 to Horde_Db. * Renamed Agora_Messages to Agora_Driver to better match other applications. I have also marked various bugs in TODO comments which I have found during testing. They exist in old version too. As soon as this is commited I can start fixing those and cleaning the code (oh yes it is a mess :)).